Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1006)

Unified Diff: third_party/WebKit/public/platform/WebURLRequest.h

Issue 2714423002: Rename SkipServiceWorker to ServiceWorkerMode (Closed)
Patch Set: typos-- Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/testing/weburl_loader_mock.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/platform/WebURLRequest.h
diff --git a/third_party/WebKit/public/platform/WebURLRequest.h b/third_party/WebKit/public/platform/WebURLRequest.h
index 84aa69ff411b5fe2604d8ec9fe8eb8abba02870d..37aedaee7b4ad260354a5d03b7b31d7abaf541d9 100644
--- a/third_party/WebKit/public/platform/WebURLRequest.h
+++ b/third_party/WebKit/public/platform/WebURLRequest.h
@@ -153,16 +153,17 @@ class WebURLRequest {
PreviewsStateLast = PreviewsOff
};
- // Indicates which types of ServiceWorkers should skip handling this request.
- enum class SkipServiceWorker {
- // Request can be handled both by a controlling same-origin worker and
- // a cross-origin foreign fetch service worker.
- None,
- // Request should not be handled by a same-origin controlling worker,
- // but can be intercepted by a foreign fetch service worker.
- Controlling,
- // Request should skip all possible service workers.
- All
+ // Indicates which service workers will receive fetch events for this request.
+ enum class ServiceWorkerMode {
+ // Relevant local and foreign service workers will get a fetch or
+ // foreignfetch event for this request.
+ All,
+ // Only relevant foreign service workers will get a foreignfetch event for
+ // this request.
+ Foreign,
+ // Neither local nor foreign service workers will get events for this
+ // request.
+ None
};
enum class LoadingIPCType {
@@ -273,9 +274,10 @@ class WebURLRequest {
BLINK_PLATFORM_EXPORT bool useStreamOnResponse() const;
BLINK_PLATFORM_EXPORT void setUseStreamOnResponse(bool);
- // True if the request should not be handled by the ServiceWorker.
- BLINK_PLATFORM_EXPORT SkipServiceWorker skipServiceWorker() const;
- BLINK_PLATFORM_EXPORT void setSkipServiceWorker(SkipServiceWorker);
+ // The service worker mode indicating which service workers should get events
+ // for this request.
+ BLINK_PLATFORM_EXPORT ServiceWorkerMode getServiceWorkerMode() const;
+ BLINK_PLATFORM_EXPORT void setServiceWorkerMode(ServiceWorkerMode);
// True if corresponding AppCache group should be resetted.
BLINK_PLATFORM_EXPORT bool shouldResetAppCache() const;
« no previous file with comments | « third_party/WebKit/Source/platform/testing/weburl_loader_mock.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698