Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: src/compiler/wasm-compiler.cc

Issue 2714403004: [wasm] wasm-compiler: Remove unused parameter on MemSize method (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/wasm-compiler.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/wasm-compiler.cc
diff --git a/src/compiler/wasm-compiler.cc b/src/compiler/wasm-compiler.cc
index 2dc1db6df18190cf1669a20f36887f7be72d0d65..57185a5070a5752575fef14436a5b0d232e9e807 100644
--- a/src/compiler/wasm-compiler.cc
+++ b/src/compiler/wasm-compiler.cc
@@ -3068,18 +3068,13 @@ Node* WasmGraphBuilder::CurrentMemoryPages() {
return result;
}
-Node* WasmGraphBuilder::MemSize(uint32_t offset) {
- DCHECK(module_ && module_->instance);
- uint32_t size = static_cast<uint32_t>(module_->instance->mem_size);
- if (offset == 0) {
- if (!mem_size_)
- mem_size_ = jsgraph()->RelocatableInt32Constant(
- size, RelocInfo::WASM_MEMORY_SIZE_REFERENCE);
- return mem_size_;
- } else {
- return jsgraph()->RelocatableInt32Constant(
- size + offset, RelocInfo::WASM_MEMORY_SIZE_REFERENCE);
- }
+Node* WasmGraphBuilder::MemSize() {
+ DCHECK_NOT_NULL(module_);
+ if (mem_size_) return mem_size_;
+ uint32_t size = module_->instance ? module_->instance->mem_size : 0;
+ mem_size_ = jsgraph()->RelocatableInt32Constant(
+ size, RelocInfo::WASM_MEMORY_SIZE_REFERENCE);
+ return mem_size_;
}
void WasmGraphBuilder::EnsureFunctionTableNodes() {
@@ -3287,8 +3282,8 @@ Node* WasmGraphBuilder::BuildAsmjsLoadMem(MachineType type, Node* index) {
// TODO(turbofan): fold bounds checks for constant asm.js loads.
// asm.js semantics use CheckedLoad (i.e. OOB reads return 0ish).
const Operator* op = jsgraph()->machine()->CheckedLoad(type);
- Node* load = graph()->NewNode(op, MemBuffer(0), index, MemSize(0), *effect_,
- *control_);
+ Node* load =
+ graph()->NewNode(op, MemBuffer(0), index, MemSize(), *effect_, *control_);
*effect_ = load;
return load;
}
@@ -3299,7 +3294,7 @@ Node* WasmGraphBuilder::BuildAsmjsStoreMem(MachineType type, Node* index,
// asm.js semantics use CheckedStore (i.e. ignore OOB writes).
const Operator* op =
jsgraph()->machine()->CheckedStore(type.representation());
- Node* store = graph()->NewNode(op, MemBuffer(0), index, MemSize(0), val,
+ Node* store = graph()->NewNode(op, MemBuffer(0), index, MemSize(), val,
*effect_, *control_);
*effect_ = store;
return val;
« no previous file with comments | « src/compiler/wasm-compiler.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698