extensions/shell/DEPS - Issue 2714393004: grit: qualify includes for shell_resources.h, virtual_driver_setup_resources.h, bluetooth_strings.h

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: extensions/shell/DEPS

Issue 2714393004: grit: qualify includes for shell_resources.h, virtual_driver_setup_resources.h, bluetooth_strings.h (Closed)

Patch Set: . Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 include_rules = [	1 include_rules = [

2 # The apps module has dependencies on chrome.	2 # The apps module has dependencies on chrome.

3 "-apps",	3 "-apps",

4	4

5 # Individual subdirectories should have their own DEPS that include	5 # Individual subdirectories should have their own DEPS that include

6 # their allowed directories.	6 # their allowed directories.

7 "-extensions/shell",	7 "-extensions/shell",

8 "+extensions/shell/common",	8 "+extensions/shell/common",

9 "+extensions/shell/test",	9 "+extensions/shell/test",

10	10

11 # Do not add dependencies on Chrome. Talk to OWNERS about how to refactor	11 # Do not add dependencies on Chrome. Talk to OWNERS about how to refactor

12 # the code you need to a shared location.	12 # the code you need to a shared location.

13 "-chrome",	13 "-chrome",

14	14

15 # The system.storage API expects the StorageMonitor to be initialized by	15 # The system.storage API expects the StorageMonitor to be initialized by

16 # the embedder before being used by the extension.	16 # the embedder before being used by the extension.

17 "+components/storage_monitor",	17 "+components/storage_monitor",

18	18

19 # Only allow app_shell and extensions resources, not general Chrome ones.

20 "-grit",

21 "+grit/app_shell_resources.h",

22 "+grit/extensions_resources.h",

23

24 # Real DEPS go in subdirectories, for example extensions/shell/browser/DEPS.	19 # Real DEPS go in subdirectories, for example extensions/shell/browser/DEPS.

25 ]	20 ]

OLD	NEW

« no previous file with comments | « extensions/shell/BUILD.gn ('k') | extensions/shell/common/DEPS » ('j') | no next file with comments »