Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 271433002: Do not call setters of read-only accessors. (Closed)

Created:
6 years, 7 months ago by ulan
Modified:
6 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Do not call setters of read-only accessors. BUG= TEST=mjsunit/readonly-accessor R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21158

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M src/objects.cc View 1 chunk +6 lines, -3 lines 0 comments Download
A + test/mjsunit/readonly-accessor.js View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ulan
PTAL
6 years, 7 months ago (2014-05-06 07:30:00 UTC) #1
Jakob Kummerow
LGTM, thanks!
6 years, 7 months ago (2014-05-06 07:36:49 UTC) #2
ulan
6 years, 7 months ago (2014-05-06 08:35:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r21158 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698