Fix unexpected blurry text caused by combination of skew and promotion

third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp

 /*
  * Copyright (C) 2009, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 129 matching lines @@
   Vector<OverlapMapContainers> m_overlapStack;
 };
 
 class CompositingRequirementsUpdater::RecursionData {
  public:
   explicit RecursionData(PaintLayer* compositingAncestor)
       : m_compositingAncestor(compositingAncestor),
         m_subtreeIsCompositing(false),
         m_hasUnisolatedCompositedBlendingDescendant(false),
         m_testingOverlap(true),
-        m_hasCompositedScrollingAncestor(false) {}
+        m_hasCompositedScrollingAncestor(false),
+        m_hasCompositedSkewedAncestor(false) {}
 
   PaintLayer* m_compositingAncestor;
   bool m_subtreeIsCompositing;
   bool m_hasUnisolatedCompositedBlendingDescendant;
   bool m_testingOverlap;
   bool m_hasCompositedScrollingAncestor;
+  bool m_hasCompositedSkewedAncestor;
 };
 
 static bool requiresCompositingOrSquashing(CompositingReasons reasons) {
 #if DCHECK_IS_ON()
   bool fastAnswer = reasons != CompositingReasonNone;
   bool slowAnswer = requiresCompositing(reasons) || requiresSquashing(reasons);
   DCHECK_EQ(slowAnswer, fastAnswer);
 #endif
   return reasons != CompositingReasonNone;
 }
@@ skipping 343 matching lines @@
     }
 
     if (willBeCompositedOrSquashed &&
         layer->layoutObject().style()->hasBlendMode())
       currentRecursionData.m_hasUnisolatedCompositedBlendingDescendant = true;
 
     // Tell the parent it has compositing descendants.
     if (willBeCompositedOrSquashed)
       currentRecursionData.m_subtreeIsCompositing = true;
 
+    // If an skewed element is composited due to its descendants, we have to

[flackr, 2017/02/28 21:40:14]

We want the opposite behavior, the descendant should be composited if its
ancestor is skewed and was composited.

+    // update the uncomposited skewed descendants to composite them.
+    if (currentRecursionData.m_subtreeIsCompositing &&
+        layer->layoutObject().styleRef().hasTransform() &&
+        layer->layoutObject().styleRef().transform().hasSkew()) {
+      childRecursionData.m_hasCompositedSkewedAncestor = true;
+
+      PaintLayerStackingNodeIterator iterator(
+          *layer->stackingNode(), NormalFlowChildren | PositiveZOrderChildren);
+      while (PaintLayerStackingNode* curNode = iterator.next()) {
+        IntRect absoluteChildDescendantBoundingBox;
+        updateRecursive(layer, curNode->layer(), overlapMap, childRecursionData,
+                        anyDescendantHas3DTransform, unclippedDescendants,
+                        absoluteChildDescendantBoundingBox);
+        absoluteDescendantBoundingBox.unite(absoluteChildDescendantBoundingBox);
+      }
+    }
+
+    // Promote skewed elements within a promoted skewed element to improve
+    // output quality.
+    if (canBeComposited && !willBeCompositedOrSquashed &&
+        currentRecursionData.m_hasCompositedSkewedAncestor) {
+      if (layer->layoutObject().styleRef().hasTransform()) {
+        if (layer->layoutObject().styleRef().transform().hasSkew()) {
+          reasonsToComposite |=
+              CompositingReasonSkewWithCompositedSkewedAncestor;
+        }
+      }
+    }
+
     // Turn overlap testing off for later layers if it's already off, or if we
     // have an animating transform.  Note that if the layer clips its
     // descendants, there's no reason to propagate the child animation to the
     // parent layers. That's because we know for sure the animation is contained
     // inside the clipping rectangle, which is already added to the overlap map.
     bool isCompositedClippingLayer =
         canBeComposited &&
         (reasonsToComposite & CompositingReasonClipsCompositingDescendants);
     bool isCompositedWithInlineTransform =
         reasonsToComposite & CompositingReasonInlineTransform;
     if ((!childRecursionData.m_testingOverlap && !isCompositedClippingLayer) ||
         layer->layoutObject().style()->hasCurrentTransformAnimation() ||
         isCompositedWithInlineTransform)
       currentRecursionData.m_testingOverlap = false;
 
     if (childRecursionData.m_compositingAncestor == layer)
       overlapMap.finishCurrentOverlapTestingContext();
 
     descendantHas3DTransform |=
         anyDescendantHas3DTransform || layer->has3DTransform();
   }
 
   // At this point we have finished collecting all reasons to composite this
   // layer.
   layer->setCompositingReasons(reasonsToComposite);
 }
 
 }  // namespace blink