Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Side by Side Diff: third_party/WebKit/Source/platform/graphics/CompositingReasons.h

Issue 2714283002: Fix unexpected blurry text caused by combination of skew and promotion (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CompositingReasons_h 5 #ifndef CompositingReasons_h
6 #define CompositingReasons_h 6 #define CompositingReasons_h
7 7
8 #include "platform/PlatformExport.h" 8 #include "platform/PlatformExport.h"
9 #include "wtf/Allocator.h" 9 #include "wtf/Allocator.h"
10 #include "wtf/text/WTFString.h" 10 #include "wtf/text/WTFString.h"
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 << 48; 91 << 48;
92 // Composited layer painted on top of all other layers as decoration 92 // Composited layer painted on top of all other layers as decoration
93 const uint64_t CompositingReasonLayerForDecoration = UINT64_C(1) << 49; 93 const uint64_t CompositingReasonLayerForDecoration = UINT64_C(1) << 49;
94 94
95 // Composited elements with inline transforms trigger assumed overlap so that 95 // Composited elements with inline transforms trigger assumed overlap so that
96 // we can update their transforms quickly. 96 // we can update their transforms quickly.
97 const uint64_t CompositingReasonInlineTransform = UINT64_C(1) << 50; 97 const uint64_t CompositingReasonInlineTransform = UINT64_C(1) << 50;
98 98
99 const uint64_t CompositingReasonCompositorProxy = UINT64_C(1) << 51; 99 const uint64_t CompositingReasonCompositorProxy = UINT64_C(1) << 51;
100 100
101 // Composited elements with counter-skewed text
102 const uint64_t CompositingReasonLayerForTextWithinSkewedPromotedElement =
flackr 2017/02/25 15:16:19 nit: how about CompositingReasonSkewWithComposited
yigu 2017/02/27 22:03:42 Done.
103 UINT64_C(1) << 52;
104
101 // Various combinations of compositing reasons are defined here also, for more 105 // Various combinations of compositing reasons are defined here also, for more
102 // intutive and faster bitwise logic. 106 // intutive and faster bitwise logic.
103 const uint64_t CompositingReasonComboAllDirectReasons = 107 const uint64_t CompositingReasonComboAllDirectReasons =
104 CompositingReason3DTransform | CompositingReasonVideo | 108 CompositingReason3DTransform | CompositingReasonVideo |
105 CompositingReasonCanvas | CompositingReasonPlugin | 109 CompositingReasonCanvas | CompositingReasonPlugin |
106 CompositingReasonIFrame | CompositingReasonBackfaceVisibilityHidden | 110 CompositingReasonIFrame | CompositingReasonBackfaceVisibilityHidden |
107 CompositingReasonActiveAnimation | CompositingReasonTransitionProperty | 111 CompositingReasonActiveAnimation | CompositingReasonTransitionProperty |
108 CompositingReasonScrollDependentPosition | 112 CompositingReasonScrollDependentPosition |
109 CompositingReasonOverflowScrollingTouch | 113 CompositingReasonOverflowScrollingTouch |
110 CompositingReasonOverflowScrollingParent | 114 CompositingReasonOverflowScrollingParent |
(...skipping 18 matching lines...) Expand all
129 CompositingReasonClipsCompositingDescendants | 133 CompositingReasonClipsCompositingDescendants |
130 CompositingReasonPositionFixedWithCompositedDescendants; 134 CompositingReasonPositionFixedWithCompositedDescendants;
131 135
132 const uint64_t CompositingReasonCombo3DDescendants = 136 const uint64_t CompositingReasonCombo3DDescendants =
133 CompositingReasonPreserve3DWith3DDescendants | 137 CompositingReasonPreserve3DWith3DDescendants |
134 CompositingReasonPerspectiveWith3DDescendants; 138 CompositingReasonPerspectiveWith3DDescendants;
135 139
136 const uint64_t CompositingReasonComboAllStyleDeterminedReasons = 140 const uint64_t CompositingReasonComboAllStyleDeterminedReasons =
137 CompositingReasonComboAllDirectStyleDeterminedReasons | 141 CompositingReasonComboAllDirectStyleDeterminedReasons |
138 CompositingReasonComboCompositedDescendants | 142 CompositingReasonComboCompositedDescendants |
139 CompositingReasonCombo3DDescendants | CompositingReasonInlineTransform; 143 CompositingReasonCombo3DDescendants | CompositingReasonInlineTransform |
144 CompositingReasonLayerForTextWithinSkewedPromotedElement;
140 145
141 const uint64_t CompositingReasonComboReasonsThatRequireOwnBacking = 146 const uint64_t CompositingReasonComboReasonsThatRequireOwnBacking =
142 CompositingReasonComboAllDirectReasons | CompositingReasonOverlap | 147 CompositingReasonComboAllDirectReasons | CompositingReasonOverlap |
143 CompositingReasonAssumedOverlap | CompositingReasonNegativeZIndexChildren | 148 CompositingReasonAssumedOverlap | CompositingReasonNegativeZIndexChildren |
144 CompositingReasonSquashingDisallowed | 149 CompositingReasonSquashingDisallowed |
145 CompositingReasonTransformWithCompositedDescendants | 150 CompositingReasonTransformWithCompositedDescendants |
146 CompositingReasonOpacityWithCompositedDescendants | 151 CompositingReasonOpacityWithCompositedDescendants |
147 CompositingReasonMaskWithCompositedDescendants | 152 CompositingReasonMaskWithCompositedDescendants |
148 CompositingReasonFilterWithCompositedDescendants | 153 CompositingReasonFilterWithCompositedDescendants |
149 CompositingReasonBlendingWithCompositedDescendants | 154 CompositingReasonBlendingWithCompositedDescendants |
150 CompositingReasonIsolateCompositedDescendants | 155 CompositingReasonIsolateCompositedDescendants |
151 CompositingReasonPreserve3DWith3DDescendants | // preserve-3d has to create 156 CompositingReasonPreserve3DWith3DDescendants | // preserve-3d has to create
152 // a backing store to ensure 157 // a backing store to ensure
153 // that 3d-transformed 158 // that 3d-transformed
154 // elements intersect. 159 // elements intersect.
155 CompositingReasonBackdropFilter | 160 CompositingReasonBackdropFilter |
156 CompositingReasonPositionFixedWithCompositedDescendants; 161 CompositingReasonPositionFixedWithCompositedDescendants |
162 CompositingReasonLayerForTextWithinSkewedPromotedElement;
157 163
158 const uint64_t CompositingReasonComboSquashableReasons = 164 const uint64_t CompositingReasonComboSquashableReasons =
159 CompositingReasonOverlap | CompositingReasonAssumedOverlap | 165 CompositingReasonOverlap | CompositingReasonAssumedOverlap |
160 CompositingReasonOverflowScrollingParent; 166 CompositingReasonOverflowScrollingParent;
161 167
162 typedef uint64_t CompositingReasons; 168 typedef uint64_t CompositingReasons;
163 169
164 // Any reasons other than overlap or assumed overlap will require the layer to 170 // Any reasons other than overlap or assumed overlap will require the layer to
165 // be separately compositing. 171 // be separately compositing.
166 inline bool requiresCompositing(CompositingReasons reasons) { 172 inline bool requiresCompositing(CompositingReasons reasons) {
(...skipping 15 matching lines...) Expand all
182 }; 188 };
183 189
184 PLATFORM_EXPORT extern const CompositingReasonStringMap 190 PLATFORM_EXPORT extern const CompositingReasonStringMap
185 kCompositingReasonStringMap[]; 191 kCompositingReasonStringMap[];
186 PLATFORM_EXPORT extern const size_t kNumberOfCompositingReasons; 192 PLATFORM_EXPORT extern const size_t kNumberOfCompositingReasons;
187 PLATFORM_EXPORT String compositingReasonsAsString(CompositingReasons); 193 PLATFORM_EXPORT String compositingReasonsAsString(CompositingReasons);
188 194
189 } // namespace blink 195 } // namespace blink
190 196
191 #endif // CompositingReasons_h 197 #endif // CompositingReasons_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698