third_party/WebKit/LayoutTests/compositing/text-within-skewed-promoted-element.html - Issue 2714283002: Fix unexpected blurry text caused by combination of skew and promotion

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/compositing/text-within-skewed-promoted-element.html

Issue 2714283002: Fix unexpected blurry text caused by combination of skew and promotion (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/compositing/text-within-skewed-promoted-element-expected.png » ('j') | third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2

	3 <!--

	4 Check that separately compositing text within a skewed promoted element
	flackr 2017/02/25 15:16:18 "Check that we separately composite text within a "Check that we separately composite text within a skewed promoted element to improve the output quality. See https://crbug.com/631872." yigu 2017/02/27 22:03:41 Done. Show quoted text On 2017/02/25 15:16:18, flackr wrote: > "Check that we separately composite text within a skewed promoted element to > improve the output quality. See https://crbug.com/631872.%22 Done.
	5 can improve the output quality. See crbug.com/631872.

	6 -->

	7 <style>

	8 div.outer {

	9 transform: skew(20deg);

	10 border: 1px solid black;

	11 padding: 0 20px 0 20px;

	12 }

	13

	14 div.outer > div {

	15 transform: skew(-20deg);

	16 }

	17

	18 div.layer {

	19 will-change: transform;

	20 }

	21 </style>

	22

	23 <script type="text/javascript">

	24 function doTest() {

	25 if (window.testRunner) {

	26 window.testRunner.dumpAsTextWithPixelResults();

	27 }

	28 }

	29 window.addEventListener('load', doTest);

	30 </script>

	31

	32 <div class="outer">

	33 <div>Text which is not promoted to a layer is drawn crips with subpixel

	34 anti-aliasing.</div>

	35 </div>

	36

	37 <div class="outer layer">

	38 <div>Text which is part of a skewed layer is skewed after it's rastered
	flackr 2017/02/25 15:16:18 I think we need a unit test to verify the specific I think we need a unit test to verify the specific promoted layers. See CompositingReasonFinderTest.cpp. yigu 2017/02/27 22:03:41 Done. Show quoted text On 2017/02/25 15:16:18, flackr wrote: > I think we need a unit test to verify the specific promoted layers. See > CompositingReasonFinderTest.cpp. Done.
	39 (with the counter-skew) resulting in extremely blurry text.

	40 But if that text is separately composited, then it's rastered into a

	41 rectilinear layer so it looks crisp (but doesn't get subpixel

	42 antialiasing because it's promoted)

	43 </div>

	44 </div>

OLD	NEW