Chromium Code Reviews Chromium Code Reviews
Issue 2714223002:
Convert more WaveShaper tests to testharness (Closed)
| Index: third_party/WebKit/LayoutTests/webaudio/WaveShaper/waveshaper-364379.html |
| diff --git a/third_party/WebKit/LayoutTests/webaudio/WaveShaper/waveshaper-364379.html b/third_party/WebKit/LayoutTests/webaudio/WaveShaper/waveshaper-364379.html |
| index 7e7dad6f8aae57cdcbf59d589f1c4a2322eef0d7..f3792b00617e65b5a4987806dc299c2fd290cddc 100644 |
| --- a/third_party/WebKit/LayoutTests/webaudio/WaveShaper/waveshaper-364379.html |
| +++ b/third_party/WebKit/LayoutTests/webaudio/WaveShaper/waveshaper-364379.html |
| @@ -1,40 +1,34 @@ |
| <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> |
|
hongchan
2017/02/24 23:15:14
<!DOCTYPE html>
Raymond Toy
2017/02/24 23:21:24
Done.
|
| <html> |
| <head> |
| - <script src="../../resources/js-test.js"></script> |
| + <script src="../../resources/testharness.js"></script> |
| + <script src="../../resources/testharnessreport.js"></script> |
| + <script src="../resources/audit-util.js"></script> |
| + <script src="../resources/audit.js"></script> |
| </head> |
| <body> |
| - <div id="description"></div> |
| - <div id="console"></div> |
| - |
| <script> |
| - description("Test WaveShaperNode"); |
| - |
| - function runTest() { |
| - if (window.testRunner) { |
| - testRunner.dumpAsText(); |
| - testRunner.waitUntilDone(); |
| - } |
| - |
| - window.jsTestIsAsync = true; |
| + let audit = Audit.createTaskRunner(); |
| + audit.define({label: 'Test WaveShaperNode'}, (task, should) => { |
| // Simplified test from crbug.com/364379 |
| - var sampleRate = 44100; |
| - var context = new OfflineAudioContext(1, sampleRate, sampleRate); |
| - var waveShaper = context.createWaveShaper(); |
| - context.oncomplete = function () { |
| - // If we get here, we passed the test from bug 364379. Just say we succeeded. |
| - testPassed("WaveShaper successfully handled change in oversampling"); |
| - finishJSTest(); |
| + let sampleRate = 44100; |
| + let context = new OfflineAudioContext(1, sampleRate, sampleRate); |
| + let waveShaper = context.createWaveShaper(); |
| + context.oncomplete = () => { |
| + // If we get here, we passed the test from bug 364379. Just say we |
| + // succeeded. |
| + should(true, 'WaveShaper successfully handled change in oversampling') |
| + .beTrue(); |
| + task.done(); |
| }; |
| context.startRendering(); |
| waveShaper.connect(context.destination); |
| - waveShaper.oversample = "4x"; |
| - } |
| + waveShaper.oversample = '4x'; |
| + }); |
| - runTest(); |
| - successfullyParsed = true; |
| + audit.run(); |
| </script> |
| </body> |
| </html> |
