Source/core/html/HTMLDialogElement.h - Issue 27142002: Use DEFINE_NODE_TYPE_CASTS instead of using manual toHTMLFooElement()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLDialogElement.h

Issue 27142002: Use DEFINE_NODE_TYPE_CASTS instead of using manual toHTMLFooElement() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLDialogElement.h

diff --git a/Source/core/html/HTMLDialogElement.h b/Source/core/html/HTMLDialogElement.h

index 521dc79f8ceba08ab4b02963044d7aa930369009..6c635a21a26246159c3638f346c91050d36c93b7 100644

--- a/Source/core/html/HTMLDialogElement.h

+++ b/Source/core/html/HTMLDialogElement.h

@@ -61,11 +61,7 @@ private:

String m_returnValue;

};

-inline HTMLDialogElement* toHTMLDialogElement(Node* node)

- ASSERT_WITH_SECURITY_IMPLICATION(!node || node->hasTagName(HTMLNames::dialogTag));

- return static_cast<HTMLDialogElement*>(node);

+DEFINE_NODE_TYPE_CASTS(HTMLDialogElement, hasTagName(HTMLNames::dialogTag));

} // namespace WebCore

« no previous file with comments | « Source/core/html/HTMLDataListElement.h ('k') | Source/core/html/HTMLDivElement.h » ('j') | no next file with comments »