Issue 2714193003: Made CC tests parameterized, rather than flag-driven.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2714193003: Made CC tests parameterized, rather than flag-driven. (Closed)

Created:
3 years, 10 months ago by Victor Vasiliev

Modified:
3 years, 9 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Made CC tests parameterized, rather than flag-driven. There were a bunch of experimental options that exercised in these tests, which can also be turned on/off via flag. I originally made the tests flag-driven, rather than parameterized, because I thought it was simpler. The problem is that I need to continue exercising all these options on/off, even if the corresponding flags are deprecated. Modified the tests to be parameterized, rather than flag-driven. Merge internal change: 147482813 Merge internal change: 147545951 Merge internal change: 147860051 R=rch@chromium.org BUG=

Patch Set 1 #

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+204 lines, -59 lines)			Patch
M	net/quic/core/congestion_control/cubic_bytes_test.cc	View	15 chunks	+94 lines, -37 lines	0 comments	Download
M	net/quic/core/congestion_control/cubic_test.cc	View	9 chunks	+60 lines, -13 lines	0 comments	Download
M	net/quic/core/congestion_control/send_algorithm_test.cc	View	4 chunks	+50 lines, -9 lines	0 comments	Download

Depends on Patchset:

Issue 2715813004 Patch 1

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages