Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGElement.cpp

Issue 2714153002: Remove LayoutSVGResourceContainer::m_id (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann
3 * <zimmermann@kde.org> 3 * <zimmermann@kde.org>
4 * Copyright (C) 2004, 2005, 2006, 2008 Rob Buis <buis@kde.org> 4 * Copyright (C) 2004, 2005, 2006, 2008 Rob Buis <buis@kde.org>
5 * Copyright (C) 2008 Apple Inc. All rights reserved. 5 * Copyright (C) 2008 Apple Inc. All rights reserved.
6 * Copyright (C) 2008 Alp Toker <alp@atoker.com> 6 * Copyright (C) 2008 Alp Toker <alp@atoker.com>
7 * Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au> 7 * Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 886 matching lines...) Expand 10 before | Expand all | Expand 10 after
897 897
898 void SVGElement::attributeChanged(const AttributeModificationParams& params) { 898 void SVGElement::attributeChanged(const AttributeModificationParams& params) {
899 Element::attributeChanged(params); 899 Element::attributeChanged(params);
900 900
901 if (params.name == HTMLNames::idAttr) { 901 if (params.name == HTMLNames::idAttr) {
902 rebuildAllIncomingReferences(); 902 rebuildAllIncomingReferences();
903 903
904 LayoutObject* object = layoutObject(); 904 LayoutObject* object = layoutObject();
905 // Notify resources about id changes, this is important as we cache 905 // Notify resources about id changes, this is important as we cache
906 // resources by id in SVGDocumentExtensions 906 // resources by id in SVGDocumentExtensions
907 if (object && object->isSVGResourceContainer()) 907 if (object && object->isSVGResourceContainer()) {
908 toLayoutSVGResourceContainer(object)->idChanged(); 908 toLayoutSVGResourceContainer(object)->idChanged(params.oldValue,
909 params.newValue);
910 }
909 if (isConnected()) 911 if (isConnected())
910 buildPendingResourcesIfNeeded(); 912 buildPendingResourcesIfNeeded();
911 invalidateInstances(); 913 invalidateInstances();
912 return; 914 return;
913 } 915 }
914 916
915 // Changes to the style attribute are processed lazily (see 917 // Changes to the style attribute are processed lazily (see
916 // Element::getAttribute() and related methods), so we don't want changes to 918 // Element::getAttribute() and related methods), so we don't want changes to
917 // the style attribute to result in extra work here. 919 // the style attribute to result in extra work here.
918 if (params.name == HTMLNames::styleAttr) 920 if (params.name == HTMLNames::styleAttr)
(...skipping 355 matching lines...) Expand 10 before | Expand all | Expand 10 after
1274 visitor->trace(m_className); 1276 visitor->trace(m_className);
1275 Element::trace(visitor); 1277 Element::trace(visitor);
1276 } 1278 }
1277 1279
1278 const AtomicString& SVGElement::eventParameterName() { 1280 const AtomicString& SVGElement::eventParameterName() {
1279 DEFINE_STATIC_LOCAL(const AtomicString, evtString, ("evt")); 1281 DEFINE_STATIC_LOCAL(const AtomicString, evtString, ("evt"));
1280 return evtString; 1282 return evtString;
1281 } 1283 }
1282 1284
1283 } // namespace blink 1285 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698