Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.h

Issue 2714153002: Remove LayoutSVGResourceContainer::m_id (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 2 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 55
56 virtual LayoutSVGResourceType resourceType() const = 0; 56 virtual LayoutSVGResourceType resourceType() const = 0;
57 57
58 bool isSVGPaintServer() const { 58 bool isSVGPaintServer() const {
59 LayoutSVGResourceType resourceType = this->resourceType(); 59 LayoutSVGResourceType resourceType = this->resourceType();
60 return resourceType == PatternResourceType || 60 return resourceType == PatternResourceType ||
61 resourceType == LinearGradientResourceType || 61 resourceType == LinearGradientResourceType ||
62 resourceType == RadialGradientResourceType; 62 resourceType == RadialGradientResourceType;
63 } 63 }
64 64
65 void idChanged(); 65 void idChanged(const AtomicString& oldId, const AtomicString& newId);
66 66
67 void invalidateCacheAndMarkForLayout(SubtreeLayoutScope* = nullptr); 67 void invalidateCacheAndMarkForLayout(SubtreeLayoutScope* = nullptr);
68 68
69 static void markForLayoutAndParentResourceInvalidation( 69 static void markForLayoutAndParentResourceInvalidation(
70 LayoutObject*, 70 LayoutObject*,
71 bool needsLayout = true); 71 bool needsLayout = true);
72 72
73 void clearInvalidationMask() { m_invalidationMask = 0; } 73 void clearInvalidationMask() { m_invalidationMask = 0; }
74 74
75 protected: 75 protected:
(...skipping 16 matching lines...) Expand all
92 void willBeDestroyed() override; 92 void willBeDestroyed() override;
93 93
94 bool m_isInLayout; 94 bool m_isInLayout;
95 95
96 private: 96 private:
97 friend class SVGResourcesCache; 97 friend class SVGResourcesCache;
98 void addClient(LayoutObject*); 98 void addClient(LayoutObject*);
99 void removeClient(LayoutObject*); 99 void removeClient(LayoutObject*);
100 void detachAllClients(); 100 void detachAllClients();
101 101
102 AtomicString m_id;
103 // Track global (markAllClientsForInvalidation) invals to avoid redundant 102 // Track global (markAllClientsForInvalidation) invals to avoid redundant
104 // crawls. 103 // crawls.
105 unsigned m_invalidationMask : 8; 104 unsigned m_invalidationMask : 8;
106 105
107 unsigned m_registered : 1; 106 unsigned m_registered : 1;
108 unsigned m_isInvalidating : 1; 107 unsigned m_isInvalidating : 1;
109 // 22 padding bits available 108 // 22 padding bits available
110 109
111 HashSet<LayoutObject*> m_clients; 110 HashSet<LayoutObject*> m_clients;
112 }; 111 };
(...skipping 13 matching lines...) Expand all
126 isSVGResourceContainer()); 125 isSVGResourceContainer());
127 126
128 #define DEFINE_LAYOUT_SVG_RESOURCE_TYPE_CASTS(thisType, typeName) \ 127 #define DEFINE_LAYOUT_SVG_RESOURCE_TYPE_CASTS(thisType, typeName) \
129 DEFINE_TYPE_CASTS(thisType, LayoutSVGResourceContainer, resource, \ 128 DEFINE_TYPE_CASTS(thisType, LayoutSVGResourceContainer, resource, \
130 resource->resourceType() == typeName, \ 129 resource->resourceType() == typeName, \
131 resource.resourceType() == typeName) 130 resource.resourceType() == typeName)
132 131
133 } // namespace blink 132 } // namespace blink
134 133
135 #endif 134 #endif
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698