Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 2714083002: Revert "Fixed issue in MallocHooks where a MallocHookScope was accidentally removed during a merge,… (Closed)

Created:
3 years, 10 months ago by bkonyi
Modified:
3 years, 10 months ago
Reviewers:
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Fixed issue in MallocHooks where a MallocHookScope was accidentally removed during a merge, causing a deadlock in the hooks. Also turned off stack trace collection in a test that was timing out as a result of the stack trace collection." This reverts commit 44a9a4ede3aeec288396d1c169734c4d58853e21. BUG= Committed: https://github.com/dart-lang/sdk/commit/1a5b555aa9fa359f74f6613bdf52b0f6117e31b6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -708 lines) Patch
M runtime/vm/benchmark_test.h View 3 chunks +0 lines, -6 lines 0 comments Download
M runtime/vm/dart.cc View 3 chunks +1 line, -14 lines 0 comments Download
M runtime/vm/hash_map.h View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/malloc_hooks.h View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/malloc_hooks.cc View 12 chunks +88 lines, -211 lines 0 comments Download
M runtime/vm/malloc_hooks_test.cc View 3 chunks +4 lines, -103 lines 0 comments Download
M runtime/vm/malloc_hooks_unsupported.cc View 3 chunks +2 lines, -19 lines 0 comments Download
M runtime/vm/object_test.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M runtime/vm/os.h View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/vm/os_android.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M runtime/vm/os_fuchsia.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M runtime/vm/os_linux.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M runtime/vm/os_macos.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M runtime/vm/os_thread.h View 2 chunks +2 lines, -10 lines 0 comments Download
M runtime/vm/os_win.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/profiler.h View 12 chunks +15 lines, -29 lines 0 comments Download
M runtime/vm/profiler.cc View 23 chunks +51 lines, -128 lines 0 comments Download
M runtime/vm/profiler_service.h View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/profiler_service.cc View 6 chunks +10 lines, -44 lines 0 comments Download
M runtime/vm/profiler_test.cc View 52 chunks +56 lines, -57 lines 0 comments Download
M runtime/vm/service.cc View 2 chunks +0 lines, -24 lines 0 comments Download
M runtime/vm/snapshot_test.cc View 3 chunks +0 lines, -9 lines 0 comments Download
M runtime/vm/source_report.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/disassemble_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
bkonyi
3 years, 10 months ago (2017-02-24 03:21:09 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1a5b555aa9fa359f74f6613bdf52b0f6117e31b6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698