Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2714043003: [ios] Creates ToolsMenuModel Class (Closed)

Created:
3 years, 10 months ago by sczs
Modified:
3 years, 10 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Creates ToolsMenuModel Class Extracts the Model related code from ToolsMenuViewController to a new class named ToolsMenuModel. This CL is just the first step on refactoring and decoupling the Model logic, so it can be used by the new ToolsMenuVC and the old one. 2706293008 got reverted and this is the fixed version. BUG=682880

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -19 lines) Patch
A ios/chrome/browser/ui/tools_menu/tools_menu_model.h View 1 chunk +83 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tools_menu/tools_menu_model.mm View 1 chunk +119 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h View 1 chunk +0 lines, -18 lines 0 comments Download
M ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
sczs
Hi Mark, Rohit, An internal test was failing so I had to revert the original ...
3 years, 10 months ago (2017-02-24 02:08:51 UTC) #3
sczs
On 2017/02/24 02:08:51, sczs wrote: > Hi Mark, Rohit, > > An internal test was ...
3 years, 10 months ago (2017-02-24 05:58:51 UTC) #4
marq (ping after 24h)
3 years, 10 months ago (2017-02-24 10:01:38 UTC) #5
On 2017/02/24 05:58:51, sczs wrote:
> On 2017/02/24 02:08:51, sczs wrote:
> > Hi Mark, Rohit,
> > 
> > An internal test was failing so I had to revert the original CL. I've now
> fixed
> > that and also created a downstream CL to fix the test. Could you PTAL.
> > 
> > Thanks
> 
> Please disregard this CL, I'll create 2 upstream CL's so I don't break the
> auto-roller.

Please close this CL in that case.

Powered by Google App Engine
This is Rietveld 408576698