Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5148)

Unified Diff: cc/trees/scroll_node.cc

Issue 2714043002: Store non-fast scrollable regions on ScrollNode (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/scroll_node.cc
diff --git a/cc/trees/scroll_node.cc b/cc/trees/scroll_node.cc
index 18b5d42d974b2515f92aa940c69d882f784fe73c..14431e645508d39524a381e62e605aa3b247f70f 100644
--- a/cc/trees/scroll_node.cc
+++ b/cc/trees/scroll_node.cc
@@ -19,7 +19,6 @@ ScrollNode::ScrollNode()
scrollable(false),
main_thread_scrolling_reasons(
MainThreadScrollingReason::kNotScrollingOnMain),
- contains_non_fast_scrollable_region(false),
max_scroll_offset_affected_by_page_scale(false),
is_inner_viewport_scroll_layer(false),
is_outer_viewport_scroll_layer(false),
@@ -35,8 +34,7 @@ bool ScrollNode::operator==(const ScrollNode& other) const {
owning_layer_id == other.owning_layer_id &&
scrollable == other.scrollable &&
main_thread_scrolling_reasons == other.main_thread_scrolling_reasons &&
- contains_non_fast_scrollable_region ==
- other.contains_non_fast_scrollable_region &&
+ non_fast_scrollable_region == other.non_fast_scrollable_region &&
wkorman 2017/02/27 23:59:24 And the SkRegion operator== logic is more complex
scroll_clip_layer_bounds == other.scroll_clip_layer_bounds &&
bounds == other.bounds &&
max_scroll_offset_affected_by_page_scale ==

Powered by Google App Engine
This is Rietveld 408576698