Chromium Code Reviews Chromium Code Reviews
Issue 2714023002:
Extension Docs: Document asyncBlocking in the Web Request API Docs. (Closed)
| Index: extensions/common/api/web_request.json |
| diff --git a/extensions/common/api/web_request.json b/extensions/common/api/web_request.json |
| index 2aeecc85e22d300d029203d4fa37e4f0c55aef8e..a3b7c4be5802a3b341f04bfef7d238826ccb8f55 100644 |
| --- a/extensions/common/api/web_request.json |
| +++ b/extensions/common/api/web_request.json |
| @@ -362,7 +362,7 @@ |
| "name": "onAuthRequired", |
| "nocompile": true, |
| "type": "function", |
| - "description": "Fired when an authentication failure is received. The listener has three options: it can provide authentication credentials, it can cancel the request and display the error page, or it can take no action on the challenge. If bad user credentials are provided, this may be called multiple times for the same request.", |
| + "description": "Fired when an authentication failure is received. The listener has three options: it can provide authentication credentials, it can cancel the request and display the error page, or it can take no action on the challenge. If bad user credentials are provided, this may be called multiple times for the same request. Note, only one of <code>'blocking'</code> or <code>'asyncBlocking'</code> modes must be specified.", |
|
lazyboy
2017/02/24 00:17:22
.. modes can be specified in <code>extraInfoSpec</
karandeepb
2017/02/24 01:04:39
Done.
|
| "parameters": [ |
| { |
| "type": "object", |
| @@ -388,7 +388,8 @@ |
| { |
| "type": "function", |
| "optional": true, |
| - "name": "callback", |
| + "description" : "Only valid if <code>'asyncBlocking'</code> is specified as one of the <code>OnAuthRequiredOptions</code>.", |
| + "name": "async_callback", |
|
lazyboy
2017/02/24 00:17:22
nit: asyncCallback
karandeepb
2017/02/24 01:04:39
Done.
|
| "parameters": [ |
| {"name": "response", "$ref": "BlockingResponse"} |
| ] |
