Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1667)

Unified Diff: net/quic/core/quic_received_packet_manager.h

Issue 2713963003: Simplify QuicReceivedPacketManager by combining DontWaitForPacketsBefore and UpdatePacketInformatio… (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/core/quic_received_packet_manager.h
diff --git a/net/quic/core/quic_received_packet_manager.h b/net/quic/core/quic_received_packet_manager.h
index 140a825f9e07d757790b6e9c27f3de23346eb866..08001a84e86254970212ef48f51fa1628e994ac1 100644
--- a/net/quic/core/quic_received_packet_manager.h
+++ b/net/quic/core/quic_received_packet_manager.h
@@ -15,7 +15,6 @@ namespace net {
namespace test {
class QuicConnectionPeer;
-class QuicReceivedPacketManagerPeer;
} // namespace test
struct QuicConnectionStats;
@@ -43,9 +42,10 @@ class QUIC_EXPORT_PRIVATE QuicReceivedPacketManager {
// another packet is received, or it will change.
const QuicFrame GetUpdatedAckFrame(QuicTime approximate_now);
- // Updates internal state based on |stop_waiting|.
- virtual void UpdatePacketInformationSentByPeer(
- const QuicStopWaitingFrame& stop_waiting);
+ // Deletes all missing packets before least unacked. The connection won't
+ // process any packets with packet number before |least_unacked| that it
+ // received after this call.
+ void DontWaitForPacketsBefore(QuicPacketNumber least_unacked);
// Returns true if there are any missing packets.
bool HasMissingPackets() const;
@@ -67,13 +67,6 @@ class QUIC_EXPORT_PRIVATE QuicReceivedPacketManager {
private:
friend class test::QuicConnectionPeer;
- friend class test::QuicReceivedPacketManagerPeer;
-
- // Deletes all missing packets before least unacked. The connection won't
- // process any packets with packet number before |least_unacked| that it
- // received after this call. Returns true if there were missing packets before
- // |least_unacked| unacked, false otherwise.
- bool DontWaitForPacketsBefore(QuicPacketNumber least_unacked);
// Least packet number of the the packet sent by the peer for which it
// hasn't received an ack.
« no previous file with comments | « net/quic/core/quic_multipath_received_packet_manager_test.cc ('k') | net/quic/core/quic_received_packet_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698