Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Side by Side Diff: net/quic/core/quic_received_packet_manager_test.cc

Issue 2713963003: Simplify QuicReceivedPacketManager by combining DontWaitForPacketsBefore and UpdatePacketInformatio… (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/core/quic_received_packet_manager.h" 5 #include "net/quic/core/quic_received_packet_manager.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <ostream> 8 #include <ostream>
9 #include <vector> 9 #include <vector>
10 10
11 #include "net/quic/core/quic_connection_stats.h" 11 #include "net/quic/core/quic_connection_stats.h"
12 #include "net/quic/test_tools/quic_received_packet_manager_peer.h"
13 #include "testing/gtest/include/gtest/gtest.h" 12 #include "testing/gtest/include/gtest/gtest.h"
14 13
15 namespace net { 14 namespace net {
16 namespace test { 15 namespace test {
17 namespace { 16 namespace {
18 17
19 struct TestParams { 18 struct TestParams {
20 explicit TestParams(QuicVersion version) : version(version) {} 19 explicit TestParams(QuicVersion version) : version(version) {}
21 20
22 friend std::ostream& operator<<(std::ostream& os, const TestParams& p) { 21 friend std::ostream& operator<<(std::ostream& os, const TestParams& p) {
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 ::testing::ValuesIn(GetTestParams())); 60 ::testing::ValuesIn(GetTestParams()));
62 61
63 TEST_P(QuicReceivedPacketManagerTest, DontWaitForPacketsBefore) { 62 TEST_P(QuicReceivedPacketManagerTest, DontWaitForPacketsBefore) {
64 QuicPacketHeader header; 63 QuicPacketHeader header;
65 header.packet_number = 2u; 64 header.packet_number = 2u;
66 received_manager_.RecordPacketReceived(header, QuicTime::Zero()); 65 received_manager_.RecordPacketReceived(header, QuicTime::Zero());
67 header.packet_number = 7u; 66 header.packet_number = 7u;
68 received_manager_.RecordPacketReceived(header, QuicTime::Zero()); 67 received_manager_.RecordPacketReceived(header, QuicTime::Zero());
69 EXPECT_TRUE(received_manager_.IsAwaitingPacket(3u)); 68 EXPECT_TRUE(received_manager_.IsAwaitingPacket(3u));
70 EXPECT_TRUE(received_manager_.IsAwaitingPacket(6u)); 69 EXPECT_TRUE(received_manager_.IsAwaitingPacket(6u));
71 EXPECT_TRUE(QuicReceivedPacketManagerPeer::DontWaitForPacketsBefore( 70 received_manager_.DontWaitForPacketsBefore(4);
72 &received_manager_, 4));
73 EXPECT_FALSE(received_manager_.IsAwaitingPacket(3u)); 71 EXPECT_FALSE(received_manager_.IsAwaitingPacket(3u));
74 EXPECT_TRUE(received_manager_.IsAwaitingPacket(6u)); 72 EXPECT_TRUE(received_manager_.IsAwaitingPacket(6u));
75 } 73 }
76 74
77 TEST_P(QuicReceivedPacketManagerTest, GetUpdatedAckFrame) { 75 TEST_P(QuicReceivedPacketManagerTest, GetUpdatedAckFrame) {
78 QuicPacketHeader header; 76 QuicPacketHeader header;
79 header.packet_number = 2u; 77 header.packet_number = 2u;
80 QuicTime two_ms = QuicTime::Zero() + QuicTime::Delta::FromMilliseconds(2); 78 QuicTime two_ms = QuicTime::Zero() + QuicTime::Delta::FromMilliseconds(2);
81 EXPECT_FALSE(received_manager_.ack_frame_updated()); 79 EXPECT_FALSE(received_manager_.ack_frame_updated());
82 received_manager_.RecordPacketReceived(header, two_ms); 80 received_manager_.RecordPacketReceived(header, two_ms);
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 QuicTime::Zero() + QuicTime::Delta::FromMilliseconds(1)); 120 QuicTime::Zero() + QuicTime::Delta::FromMilliseconds(1));
123 121
124 EXPECT_EQ(4u, stats_.max_sequence_reordering); 122 EXPECT_EQ(4u, stats_.max_sequence_reordering);
125 EXPECT_EQ(1000, stats_.max_time_reordering_us); 123 EXPECT_EQ(1000, stats_.max_time_reordering_us);
126 EXPECT_EQ(1u, stats_.packets_reordered); 124 EXPECT_EQ(1u, stats_.packets_reordered);
127 } 125 }
128 126
129 } // namespace 127 } // namespace
130 } // namespace test 128 } // namespace test
131 } // namespace net 129 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/core/quic_received_packet_manager.cc ('k') | net/quic/test_tools/quic_received_packet_manager_peer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698