Convert more PannerNode tests to testharness

third_party/WebKit/LayoutTests/webaudio/resources/panner-model-testing.js

 var sampleRate = 44100.0;
 
 var numberOfChannels = 1;
 
 // Time step when each panner node starts.
 var timeStep = 0.001;
 
 // Length of the impulse signal.
 var pulseLengthFrames = Math.round(timeStep * sampleRate);
 
@@ skipping 44 matching lines @@
 
         bufferSource[k].connect(panner[k]);
         panner[k].connect(context.destination);
 
         // Start the source
         time[k] = k * timeStep;
         bufferSource[k].start(time[k]);
     }
 }
 
-function createTestAndRun(context, nodeCount, numberOfSourceChannels, positionSetter) {
+function createTestAndRun(context, should, nodeCount, numberOfSourceChannels, positionSetter) {

[hongchan, 2017/02/24 22:07:24]

Let's wrap this line.

[Raymond Toy, 2017/02/24 22:19:24]

Done.

     numberOfChannels = numberOfSourceChannels;
 
     createGraph(context, nodeCount, positionSetter);
 
-    context.oncomplete = checkResult;
-    context.startRendering();
+    return context.startRendering()
+        .then(buffer => checkResult(buffer, should));;

[hongchan, 2017/02/24 22:07:24]

Two semicolons.

[Raymond Toy, 2017/02/24 22:19:24]

Done.

 }
 
 // Map our position angle to the azimuth angle (in degrees).
 //
 // An angle of 0 corresponds to an azimuth of 90 deg; pi, to -90 deg.
 function angleToAzimuth(angle) {
     return 90 - angle * 180 / Math.PI;
 }
 
 // The gain caused by the EQUALPOWER panning model
@@ skipping 19 matching lines @@
             var panPosition = azimuth / 90;
     
             var gainL = Math.cos(0.5 * Math.PI * panPosition);
             var gainR = 1 + Math.sin(0.5 * Math.PI * panPosition);
     
             return { left : gainL, right : gainR };
         }
     }
 }
 
-function checkResult(event) {
-    renderedBuffer = event.renderedBuffer;
+function checkResult(renderedBuffer, should) {
     renderedLeft = renderedBuffer.getChannelData(0);
     renderedRight = renderedBuffer.getChannelData(1);
 
     // The max error we allow between the rendered impulse and the
     // expected value.  This value is experimentally determined.  Set
     // to 0 to make the test fail to see what the actual error is.
     var maxAllowedError = 1.3e-6;
   
     var success = true;
 
@@ skipping 38 matching lines @@
             // expected them to be.
             var expectedOffset = timeToSampleFrame(time[impulseCount], sampleRate);
             if (k != expectedOffset) {
                 timeErrors[timeCount] = { actual : k, expected : expectedOffset};
                 ++timeCount;
             }
             ++impulseCount;
         }
     }
 
-    if (impulseCount == nodesToCreate) {
-        testPassed("Number of impulses matches the number of panner nodes.");
-    } else {
-        testFailed("Number of impulses is incorrect.  (Found " + impulseCount + " but expected " + nodesToCreate + ")");
-        success = false;
-    }
+    should(impulseCount, "Number of impulses found")
+        .beEqualTo(nodesToCreate);
 
-    if (timeErrors.length > 0) {
-        success = false;
-        testFailed(timeErrors.length + " timing errors found in " + nodesToCreate + " panner nodes.");
-        for (var k = 0; k < timeErrors.length; ++k) {
-            testFailed("Impulse at sample " + timeErrors[k].actual + " but expected " + timeErrors[k].expected);
-        }
-    } else {
-        testPassed("All impulses at expected offsets.");
-    }
+    should(timeErrors.map(x => x.actual), "Offsets of impulses at the wrong position")
+        .beEqualToArray(timeErrors.map(x => x.expected));
 
-    if (maxErrorL <= maxAllowedError) {
-        testPassed("Left channel gain values are correct.");
-    } else {
-        testFailed("Left channel gain values are incorrect.  Max error = " + maxErrorL + " at time " + time[maxErrorIndexL] + " (threshold = " + maxAllowedError + ")");
-        success = false;
-    }
-    
-    if (maxErrorR <= maxAllowedError) {
-        testPassed("Right channel gain values are correct.");
-    } else {
-        testFailed("Right channel gain values are incorrect.  Max error = " + maxErrorR + " at time " + time[maxErrorIndexR] + " (threshold = " + maxAllowedError + ")");
-        success = false;
-    }
+    should(maxErrorL, "Error in left channel gain values")
+        .beLessThanOrEqualTo(maxAllowedError);
 
-    if (success) {
-        testPassed("EqualPower panner test passed");
-    } else {
-        testFailed("EqualPower panner test failed");
-    }
-
-    finishJSTest();
+    should(maxErrorR, "Error in right channel gain values")
+        .beLessThanOrEqualTo(maxAllowedError);
 }