Use ExtensionRegistryObserver instead of deprecated extension notification from autocomplete

chrome/browser/autocomplete/extension_app_provider_unittest.cc

Index: chrome/browser/autocomplete/extension_app_provider_unittest.cc
diff --git a/chrome/browser/autocomplete/extension_app_provider_unittest.cc b/chrome/browser/autocomplete/extension_app_provider_unittest.cc
index 0ac201aca120570dcd129d83764b7041fd9d2474..f75c56d383b0d9b26a070aac5c9e602ca7cf02ce 100644
--- a/chrome/browser/autocomplete/extension_app_provider_unittest.cc
+++ b/chrome/browser/autocomplete/extension_app_provider_unittest.cc
@@ -26,7 +26,9 @@ class ExtensionAppProviderTest : public testing::Test {
 
   ExtensionAppProviderTest()
       : ui_thread_(content::BrowserThread::UI, &message_loop_),
-        history_service_(NULL) { }
+        profile_(new TestingProfile),
+        app_provider_(new ExtensionAppProvider(NULL, profile_.get())),

[not at google - send to devlin, 2014/05/12 17:59:00]

typically we do leave this sort of initialization until SetUp. is there a
specific reason you moved it into the constructor?

[Peter Kasting, 2014/05/12 19:46:55]

The two should be equivalent, and if you _can_ init something in the constructor
initializer list, I think it's better to do so.

[limasdf, 2014/05/13 14:38:44]

Interestingly, the result is different. the original code fail from test.
|ExtensionRegistry::RemoveObserver| is called with improper observer.
Perhaps, the reason is inside of gtest::SetUp. or scoped_ptr. because of my
ignorance for them,
I just patched the issue with this method.

* Result of original code
[ RUN      ] ExtensionAppProviderTest.BasicMatching
Received signal 11 <unknown> 000000000000
#0 0x0000040a68c5 base::debug::StackTrace::StackTrace()
#1 0x0000040a61f1 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7f142bdf3cb0 <unknown>
#3 0x7f142a5bd156 <unknown>
#4 0x7f142a5bd1b2 <unknown>
#5 0x00000045045c __gnu_debug::_Safe_iterator_base::_Safe_iterator_base()
#6 0x0000088d9780 __gnu_debug::_Safe_iterator<>::_Safe_iterator()
#7 0x0000088d880b std::__debug::vector<>::end()
#8 0x0000088d82b3 ObserverListBase<>::RemoveObserver()
#9 0x0000088d7a8c extensions::ExtensionRegistry::RemoveObserver()
#10 0x00000214d269 ScopedObserver<>::RemoveAll()
#11 0x00000214c676 ScopedObserver<>::~ScopedObserver()
#12 0x00000214be62 ExtensionAppProvider::~ExtensionAppProvider()
#13 0x00000214bedc ExtensionAppProvider::~ExtensionAppProvider()

+        history_service_(NULL) {}
   virtual ~ExtensionAppProviderTest() { }
 
   virtual void SetUp() OVERRIDE;
@@ -37,21 +39,18 @@ class ExtensionAppProviderTest : public testing::Test {
  protected:
   base::MessageLoopForUI message_loop_;
   content::TestBrowserThread ui_thread_;
-  scoped_refptr<ExtensionAppProvider> app_provider_;
   scoped_ptr<TestingProfile> profile_;
+  scoped_refptr<ExtensionAppProvider> app_provider_;
   HistoryService* history_service_;
 };
 
 void ExtensionAppProviderTest::SetUp() {
-  profile_.reset(new TestingProfile());
   ASSERT_TRUE(profile_->CreateHistoryService(true, false));
   profile_->BlockUntilHistoryProcessesPendingRequests();
   history_service_ =
       HistoryServiceFactory::GetForProfile(profile_.get(),
                                            Profile::EXPLICIT_ACCESS);
 
-  app_provider_ = new ExtensionAppProvider(NULL, profile_.get());
-
   struct TestExtensionApp {
     const char* app_name;
     const char* launch_url;