Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: chrome/browser/autocomplete/extension_app_provider_unittest.cc

Issue 271393003: Use ExtensionRegistryObserver instead of deprecated extension notification from autocomplete (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: colon to period Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/extension_app_provider_unittest.cc
diff --git a/chrome/browser/autocomplete/extension_app_provider_unittest.cc b/chrome/browser/autocomplete/extension_app_provider_unittest.cc
index 0ac201aca120570dcd129d83764b7041fd9d2474..f75c56d383b0d9b26a070aac5c9e602ca7cf02ce 100644
--- a/chrome/browser/autocomplete/extension_app_provider_unittest.cc
+++ b/chrome/browser/autocomplete/extension_app_provider_unittest.cc
@@ -26,7 +26,9 @@ class ExtensionAppProviderTest : public testing::Test {
ExtensionAppProviderTest()
: ui_thread_(content::BrowserThread::UI, &message_loop_),
- history_service_(NULL) { }
+ profile_(new TestingProfile),
+ app_provider_(new ExtensionAppProvider(NULL, profile_.get())),
+ history_service_(NULL) {}
virtual ~ExtensionAppProviderTest() { }
virtual void SetUp() OVERRIDE;
@@ -37,21 +39,18 @@ class ExtensionAppProviderTest : public testing::Test {
protected:
base::MessageLoopForUI message_loop_;
content::TestBrowserThread ui_thread_;
- scoped_refptr<ExtensionAppProvider> app_provider_;
scoped_ptr<TestingProfile> profile_;
+ scoped_refptr<ExtensionAppProvider> app_provider_;
HistoryService* history_service_;
};
void ExtensionAppProviderTest::SetUp() {
- profile_.reset(new TestingProfile());
ASSERT_TRUE(profile_->CreateHistoryService(true, false));
profile_->BlockUntilHistoryProcessesPendingRequests();
history_service_ =
HistoryServiceFactory::GetForProfile(profile_.get(),
Profile::EXPLICIT_ACCESS);
- app_provider_ = new ExtensionAppProvider(NULL, profile_.get());
-
struct TestExtensionApp {
const char* app_name;
const char* launch_url;
« no previous file with comments | « chrome/browser/autocomplete/extension_app_provider.cc ('k') | chrome/browser/autocomplete/shortcuts_backend.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698