Use ExtensionRegistryObserver instead of deprecated extension notification from autocomplete

chrome/browser/autocomplete/extension_app_provider.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_AUTOCOMPLETE_EXTENSION_APP_PROVIDER_H_
 #define CHROME_BROWSER_AUTOCOMPLETE_EXTENSION_APP_PROVIDER_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/gtest_prod_util.h"
+#include "base/scoped_observer.h"
 #include "chrome/browser/autocomplete/autocomplete_input.h"
 #include "chrome/browser/autocomplete/autocomplete_match.h"
 #include "chrome/browser/autocomplete/autocomplete_provider.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
+#include "extensions/browser/extension_registry_observer.h"
 #include "ui/base/window_open_disposition.h"
 
+namespace extensions {
+class ExtensionRegistry;
+}
+
 // This provider is responsible for keeping track of which Extension Apps are
 // installed and their URLs.  An instance of it gets created and managed by
 // AutocompleteController.
 class ExtensionAppProvider : public AutocompleteProvider,
-                             public content::NotificationObserver {
+                             public content::NotificationObserver,
+                             public extensions::ExtensionRegistryObserver {
  public:
   ExtensionAppProvider(AutocompleteProviderListener* listener,
                        Profile* profile);
 
   // AutocompleteProvider:
   virtual void Start(const AutocompleteInput& input,
                      bool minimal_changes) OVERRIDE;
 
   // Launch an Extension App from |match| details provided by the Omnibox. If
   // the application wants to launch as a window or panel, |disposition| is
@@ skipping 39 matching lines @@
   int CalculateRelevance(AutocompleteInput::Type type,
                          int input_length,
                          int target_length,
                          const GURL& url);
 
   // content::NotificationObserver implementation:
   virtual void Observe(int type,
                        const content::NotificationSource& source,
                        const content::NotificationDetails& details) OVERRIDE;
 
+  // extensions::ExtensionRegistryObserver implementation.

[Peter Kasting, 2014/05/13 17:59:28]

Nit: Trailing colon, not period

[limasdf, 2014/05/13 18:04:06]

Yep, my bad.
One question, why some kind of comment finish with colon? 
AFAIK, comment should be ended with period.

[limasdf, 2014/05/13 18:04:34]

Done.

[Peter Kasting, 2014/05/13 18:15:26]

It's basically trying to say "The following methods all come from class X:
<...>".

[limasdf, 2014/05/13 18:18:06]

good notation. thanks!

+  virtual void OnExtensionLoaded(
+      content::BrowserContext* browser_context,
+      const extensions::Extension* extension) OVERRIDE;
+
   content::NotificationRegistrar registrar_;
 
+  ScopedObserver<extensions::ExtensionRegistry,
+                 extensions::ExtensionRegistryObserver>
+      extension_registry_observer_;
+
   // Our cache of ExtensionApp objects (name + url) representing the extension
   // apps we know/care about.
   ExtensionApps extension_apps_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionAppProvider);
 };
 
 #endif  // CHROME_BROWSER_AUTOCOMPLETE_EXTENSION_APP_PROVIDER_H_