Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Unified Diff: ash/common/system/tray/system_tray_unittest.cc

Issue 2713923002: chromeos: moves a bunch of tests to common_unittests (Closed)
Patch Set: tweak Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/system/tray/system_tray_unittest.cc
diff --git a/ash/common/system/tray/system_tray_unittest.cc b/ash/common/system/tray/system_tray_unittest.cc
index 092c4c6ee1717163da852cb1a7b4a105e9aa90d1..d76f249cc180231f8feb358bb54a6d3788f5cce5 100644
--- a/ash/common/system/tray/system_tray_unittest.cc
+++ b/ash/common/system/tray/system_tray_unittest.cc
@@ -204,6 +204,10 @@ TEST_F(SystemTrayTest, SystemTrayDefaultView) {
// Make sure the opening system tray bubble will not deactivate the
// other window. crbug.com/120680.
TEST_F(SystemTrayTest, Activation) {
+ // TODO: investigate why this fails in mash. http://crbug.com/695559.
+ if (WmShell::Get()->IsRunningInMash())
+ return;
+
SystemTray* tray = GetPrimarySystemTray();
std::unique_ptr<views::Widget> widget(CreateTestWidget(
nullptr, kShellWindowId_DefaultContainer, gfx::Rect(0, 0, 100, 100)));
@@ -456,6 +460,10 @@ TEST_F(SystemTrayTest, TrayBoundsInWidget) {
}
TEST_F(SystemTrayTest, PersistentBubble) {
+ // TODO: investigate why this fails in mash. http://crbug.com/695559.
+ if (WmShell::Get()->IsRunningInMash())
+ return;
+
SystemTray* tray = GetPrimarySystemTray();
ASSERT_TRUE(tray->GetWidget());

Powered by Google App Engine
This is Rietveld 408576698