Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Unified Diff: pkg/analyzer_cli/test/driver_test.dart

Issue 2713913003: Fix tests that are failing on windows (TBR) (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/pkg.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer_cli/test/driver_test.dart
diff --git a/pkg/analyzer_cli/test/driver_test.dart b/pkg/analyzer_cli/test/driver_test.dart
index 429eb3398b9cfaa01e525b0d56045e001f3c7a6e..6b7937c9ccb5b903ecc1bd078ee58222e137414a 100644
--- a/pkg/analyzer_cli/test/driver_test.dart
+++ b/pkg/analyzer_cli/test/driver_test.dart
@@ -348,7 +348,7 @@ linter:
}
test('no stats', () async {
- await doDrive('data/test_file.dart');
+ await doDrive(path.join('data', 'test_file.dart'));
// Should not print stat summary.
expect(outSink.toString(), isEmpty);
expect(errorSink.toString(), isEmpty);
@@ -358,20 +358,20 @@ linter:
test(
'Fails if file not found, even when --build-suppress-exit-code is given',
() async {
- await doDrive('data/non_existent_file.dart',
+ await doDrive(path.join('data', 'non_existent_file.dart'),
additionalArgs: ['--build-suppress-exit-code']);
expect(exitCode, isNot(0));
});
test('Fails if there are errors', () async {
- await doDrive('data/file_with_error.dart');
+ await doDrive(path.join('data', 'file_with_error.dart'));
expect(exitCode, isNot(0));
});
test(
'Succeeds if there are errors, when --build-suppress-exit-code is given',
() async {
- await doDrive('data/file_with_error.dart',
+ await doDrive(path.join('data', 'file_with_error.dart'),
additionalArgs: ['--build-suppress-exit-code']);
expect(exitCode, 0);
});
« no previous file with comments | « no previous file | pkg/pkg.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698