[sync] Add Sessions integration tests

chrome/browser/sync/test/integration/sync_test.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SYNC_TEST_INTEGRATION_SYNC_TEST_H_
 #define CHROME_BROWSER_SYNC_TEST_INTEGRATION_SYNC_TEST_H_
 
 #include <memory>
 #include <string>
 #include <vector>
@@ skipping 120 matching lines @@
   // Returns a pointer to a particular sync profile. Callee owns the object
   // and manages its lifetime.
   Profile* GetProfile(int index) WARN_UNUSED_RESULT;
 
   // Returns a list of all profiles including the verifier if available. Callee
   // owns the objects and manages its lifetime.
   std::vector<Profile*> GetAllProfiles();
 
   // Returns a pointer to a particular browser. Callee owns the object
   // and manages its lifetime.
   Browser* GetBrowser(int index) WARN_UNUSED_RESULT;

[skym, 2017/02/24 00:14:09]

Why are all these methods annotated with WARN_UNUSED_RESULT?

[Patrick Noland, 2017/02/24 01:00:40]

Good question, I'll check into that.

[Patrick Noland, 2017/02/27 18:53:26]

I removed them all and it still compiles.

 
+  // Adds a new browser belonging to the profile at |profile_index|, and appends
+  // it to the list of browsers. Creates a copy of the Profile pointer in
+  // position |profile_index| and appends it to the list of profiles. This is
+  // done so that the profile associated with the new browser can be found at

[skym, 2017/02/24 00:14:09]

What does it mean for there to be two Browsers that share a Profile? Is this the
same or different from when I have two windows open for a single profile?

[Patrick Noland, 2017/02/24 01:00:41]

It's having two windows open for the same profile.

+  // the same index as it.
+  Browser* AddBrowser(int profile_index);
+
   // Returns a pointer to a particular sync client. Callee owns the object
   // and manages its lifetime.
   ProfileSyncServiceHarness* GetClient(int index) WARN_UNUSED_RESULT;
 
   // Returns a reference to the collection of sync clients. Callee owns the
   // object and manages its lifetime.
   std::vector<ProfileSyncServiceHarness*>& clients() WARN_UNUSED_RESULT {
     return clients_.get();
   }
 
@@ skipping 305 matching lines @@
   std::unique_ptr<net::URLFetcherImplFactory> factory_;
 
   // The contents to be written to a profile's Preferences file before the
   // Profile object is created. If empty, no preexisting file will be written.
   std::string preexisting_preferences_file_contents_;
 
   DISALLOW_COPY_AND_ASSIGN(SyncTest);
 };
 
 #endif  // CHROME_BROWSER_SYNC_TEST_INTEGRATION_SYNC_TEST_H_