Index: chromecast/crash/cast_crash_keys.cc |
diff --git a/chromecast/crash/cast_crash_keys.cc b/chromecast/crash/cast_crash_keys.cc |
index 7de30624b3afe6ec9b0b6d63421da2ca3bf06670..4c756b668df619e5504f29d2d08d71cda41236c6 100644 |
--- a/chromecast/crash/cast_crash_keys.cc |
+++ b/chromecast/crash/cast_crash_keys.cc |
@@ -34,79 +34,12 @@ const char kCurrentApp[] = "current_app"; |
const char kPreviousApp[] = "previous_app"; |
size_t RegisterCastCrashKeys() { |
+ // TODO(slan|sanfin): figure out how to register these keys without having to |
+ // copy-paste the keys from chrome/common/crash_keys.cc. crbug.com/598854 |
const base::debug::CrashKey fixed_keys[] = { |
{ kLastApp, kSmallSize }, |
{ kCurrentApp, kSmallSize }, |
{ kPreviousApp, kSmallSize }, |
halliwell
2017/02/24 14:42:40
I don't understand. It seems that RegisterCastCra
Simeon
2017/02/24 19:10:50
I could just delete the function and leave a TODO.
|
- // content/: |
- { "discardable-memory-allocated", kSmallSize }, |
- { "discardable-memory-free", kSmallSize }, |
- { "ppapi_path", kMediumSize }, |
- { "subresource_url", kLargeSize }, |
- { "total-discardable-memory-allocated", kSmallSize }, |
- |
- // gin/: |
- { "v8-ignition", kSmallSize }, |
- |
- // Copied from common/crash_keys. Remove when |
- // http://crbug.com/598854 is resolved. |
- |
- // Temporary for http://crbug.com/575245 |
- { "swapout_frame_id", kSmallSize }, |
- { "swapout_proxy_id", kSmallSize }, |
- { "swapout_view_id", kSmallSize }, |
- { "commit_frame_id", kSmallSize }, |
- { "commit_proxy_id", kSmallSize }, |
- { "commit_view_id", kSmallSize }, |
- { "commit_main_render_frame_id", kSmallSize }, |
- { "newproxy_proxy_id", kSmallSize }, |
- { "newproxy_view_id", kSmallSize }, |
- { "newproxy_opener_id", kSmallSize }, |
- { "newproxy_parent_id", kSmallSize }, |
- { "rvinit_view_id", kSmallSize }, |
- { "rvinit_proxy_id", kSmallSize }, |
- { "rvinit_main_frame_id", kSmallSize }, |
- { "initrf_frame_id", kSmallSize }, |
- { "initrf_proxy_id", kSmallSize }, |
- { "initrf_view_id", kSmallSize }, |
- { "initrf_main_frame_id", kSmallSize }, |
- { "initrf_view_is_live", kSmallSize }, |
- |
- // Keys for https://crbug.com/591478 |
- { "initrf_parent_proxy_exists", kSmallSize }, |
- { "initrf_render_view_is_live", kSmallSize }, |
- { "initrf_parent_is_in_same_site_instance", kSmallSize}, |
- { "initrf_parent_process_is_live", kSmallSize}, |
- { "initrf_root_is_in_same_site_instance", kSmallSize}, |
- { "initrf_root_is_in_same_site_instance_as_parent", kSmallSize}, |
- { "initrf_root_process_is_live", kSmallSize}, |
- { "initrf_root_proxy_is_live", kSmallSize}, |
- |
- // Temporary for https://crbug.com/626802. |
- { "newframe_routing_id", kSmallSize }, |
- { "newframe_proxy_id", kSmallSize }, |
- { "newframe_opener_id", kSmallSize }, |
- { "newframe_parent_id", kSmallSize }, |
- { "newframe_widget_id", kSmallSize }, |
- { "newframe_widget_hidden", kSmallSize }, |
- { "newframe_replicated_origin", kSmallSize }, |
- { "newframe_oopifs_possible", kSmallSize }, |
- |
- // Temporary for https://crbug.com/630103. |
- { "origin_mismatch_url", kLargeSize }, |
- { "origin_mismatch_origin", kMediumSize }, |
- { "origin_mismatch_transition", kSmallSize }, |
- { "origin_mismatch_redirects", kSmallSize }, |
- { "origin_mismatch_same_page", kSmallSize }, |
- |
- // Temporary for https://crbug.com/612711. |
- { "aci_wrong_sp_extension_id", kSmallSize }, |
- |
- // Temporary for https://crbug.com/668633. |
- { "swdh_set_hosted_version_worker_pid", kSmallSize }, |
- { "swdh_set_hosted_version_host_pid", kSmallSize }, |
- { "swdh_set_hosted_version_is_new_process", kSmallSize }, |
- { "swdh_set_hosted_version_restart_count", kSmallSize }, |
}; |
return base::debug::InitCrashKeys(fixed_keys, arraysize(fixed_keys), |