Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2713803003: Revert "Updated MallocHooks to collect stack traces when memory is allocated." (Closed)

Created:
3 years, 10 months ago by bkonyi
Modified:
3 years, 10 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Updated MallocHooks to collect stack traces when memory is allocated." This reverts commit a486a8a26b51dce728373183ab02aeda70e6f2d0. R=johnmccutchan@google.com TBR=johnmccutchan@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/d4f026c2e0d7222b7ed47108a85a3945abc2fee7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -690 lines) Patch
M runtime/vm/benchmark_test.h View 3 chunks +0 lines, -6 lines 0 comments Download
M runtime/vm/dart.cc View 3 chunks +1 line, -14 lines 0 comments Download
M runtime/vm/hash_map.h View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/malloc_hooks.h View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/malloc_hooks.cc View 13 chunks +84 lines, -201 lines 0 comments Download
M runtime/vm/malloc_hooks_test.cc View 3 chunks +4 lines, -103 lines 0 comments Download
M runtime/vm/malloc_hooks_unsupported.cc View 3 chunks +2 lines, -19 lines 0 comments Download
M runtime/vm/os.h View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/vm/os_android.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M runtime/vm/os_fuchsia.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M runtime/vm/os_linux.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M runtime/vm/os_macos.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M runtime/vm/os_thread.h View 2 chunks +2 lines, -10 lines 0 comments Download
M runtime/vm/os_win.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/profiler.h View 12 chunks +15 lines, -29 lines 0 comments Download
M runtime/vm/profiler.cc View 23 chunks +51 lines, -128 lines 0 comments Download
M runtime/vm/profiler_service.h View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/profiler_service.cc View 6 chunks +10 lines, -44 lines 0 comments Download
M runtime/vm/profiler_test.cc View 52 chunks +56 lines, -57 lines 0 comments Download
M runtime/vm/service.cc View 2 chunks +0 lines, -24 lines 0 comments Download
M runtime/vm/snapshot_test.cc View 3 chunks +0 lines, -9 lines 0 comments Download
M runtime/vm/source_report.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 2700033003 Patch 20001

Messages

Total messages: 3 (1 generated)
Cutch
lgtm
3 years, 10 months ago (2017-02-23 21:09:31 UTC) #1
bkonyi
3 years, 10 months ago (2017-02-23 21:13:54 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
d4f026c2e0d7222b7ed47108a85a3945abc2fee7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698