Views/Harmony: Use LayoutDelegate::GetMetric for views::kPanelVertMargin.

chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc

Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc b/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
index 0dece36c0139322b9e8df9e2271a2b0e16969563..57453f871c15c8041f8b4e41b7201dd59edf7fa3 100644
--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
@@ -16,6 +16,7 @@
 #include "chrome/browser/ui/views/apps/app_info_dialog/app_info_header_panel.h"
 #include "chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.h"
 #include "chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.h"
+#include "chrome/browser/ui/views/harmony/layout_delegate.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/extensions/extension_constants.h"
 #include "chrome/common/features.h"
@@ -134,11 +135,11 @@ AppInfoDialog::AppInfoDialog(gfx::NativeWindow parent_window,
   // Make a vertically stacked view of all the panels we want to display in the
   // dialog.
   views::View* dialog_body_contents = new views::View();
-  dialog_body_contents->SetLayoutManager(
-      new views::BoxLayout(views::BoxLayout::kVertical,
-                           views::kButtonHEdgeMarginNew,
-                           views::kPanelVertMargin,
-                           views::kUnrelatedControlVerticalSpacing));
+  dialog_body_contents->SetLayoutManager(new views::BoxLayout(
+      views::BoxLayout::kVertical, views::kButtonHEdgeMarginNew,

[tapted, 2017/02/27 03:24:51]

Does it make sense to move views::kButtonHEdgeMarginNew as well? (if [yes], I
think it's good to include on this CL). E.g. would it be PANEL_CONTENT_MARGIN?

[Peter Kasting, 2017/02/28 02:21:39]

It's DIALOG_BUTTON_MARGIN.  The one below is UNRELATED_CONTROL_VERTICAL_SPACING.
 Many places in other touched files could also be converted.  I've been trying
to leave it up to Patti how to do this conversions and split them among CLs. 
It's fine by me to convert them in larger or smaller groups as desired.

I'd personally tend to convert directory-by-directory rather than
constant-by-constant, just because it makes it most obvious when things like the
LayoutDelegate itself should be pulled out to a temp.  But that preference need
not dictate this work.

[Patti Lor, 2017/03/03 08:24:39]

Leaving as-is (at least for this CL) - but yeah directory by directory is
probably easier. I've just been running sed on everything under chrome/, but
with all the manual work that still needs to be put in for each replacement it's
probably the same amount of time or faster to do dir-by-dir. Thanks for the
advice!

+      LayoutDelegate::Get()->GetMetric(
+          LayoutDelegate::Metric::PANEL_CONTENT_MARGIN),
+      views::kUnrelatedControlVerticalSpacing));
   dialog_body_contents->AddChildView(new AppInfoSummaryPanel(profile, app));
   dialog_body_contents->AddChildView(new AppInfoPermissionsPanel(profile, app));