Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: chrome/browser/ui/views/sad_tab_view.cc

Issue 2713803002: Views/Harmony: Use LayoutDelegate::GetMetric for views::kPanelVertMargin. (Closed)
Patch Set: Rebase. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/sad_tab_view.cc
diff --git a/chrome/browser/ui/views/sad_tab_view.cc b/chrome/browser/ui/views/sad_tab_view.cc
index 3082cb97126a4d4c643ab7681b751588468cf737..d101e07ebb94a24a73d444194e5b2550f98a25fc 100644
--- a/chrome/browser/ui/views/sad_tab_view.cc
+++ b/chrome/browser/ui/views/sad_tab_view.cc
@@ -9,6 +9,7 @@
#include "base/metrics/histogram_macros.h"
#include "build/build_config.h"
#include "chrome/app/vector_icons/vector_icons.h"
+#include "chrome/browser/ui/views/harmony/layout_delegate.h"
#include "content/public/browser/web_contents.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/resource/resource_bundle.h"
@@ -27,8 +28,9 @@
namespace {
-const int kMaxContentWidth = 600;
-const int kMinColumnWidth = 120;
+constexpr int kMaxContentWidth = 600;
+constexpr int kMinColumnWidth = 120;
+constexpr int kTitleBottomSpacing = 13;
} // namespace
@@ -79,7 +81,7 @@ SadTabView::SadTabView(content::WebContents* web_contents,
message_->SetHorizontalAlignment(gfx::ALIGN_LEFT);
message_->SetLineHeight(views::kPanelSubVerticalSpacing);
- layout->StartRowWithPadding(0, column_set_id, 0, views::kPanelVertMargin);
+ layout->StartRowWithPadding(0, column_set_id, 0, kTitleBottomSpacing);
layout->AddView(message_, 2, 1, views::GridLayout::LEADING,
views::GridLayout::LEADING);

Powered by Google App Engine
This is Rietveld 408576698