Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 27138003: Revert 228401 "Enable GPU control lists in tests." (Closed)

Created:
7 years, 2 months ago by tapted
Modified:
7 years, 2 months ago
Reviewers:
gab
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 228401 "Enable GPU control lists in tests." I'm sorry Mr CL, but you may have broken ImageTransportFactoryBrowserTest.TestLostContext in a sticky way on the XP and Vista waterfall bots. Win7 still likes you. Problems started at builders: http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/28514 http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%28dbg%29%282%29/builds/33745 http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/builds/41163 Reverting & monitoring to narrow down the problem space. > Enable GPU control lists in tests. > > Reland of https://codereview.chromium.org/23534006/ (see that and the bug for more details). > > Also adding INFO-level logging to spell out each control list rule being applied on the bots (makes debugging and understanding failures much easier). > > R=piman@chromium.org > TBR=jcivelli, piman, zmo > BUG=295799 > > Previously Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224810 > Reverted: https://src.chromium.org/viewvc/chrome?view=rev&revision=224845 > > Previously Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227977 > Reverted: https://src.chromium.org/viewvc/chrome?view=rev&revision=228014 > > Review URL: https://codereview.chromium.org/23703017 TBR=gab@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228431

Patch Set 1 #

Patch Set 2 : Go away Base files missing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -133 lines) Patch
M trunk/src/chrome/browser/gpu/chrome_gpu_util.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M trunk/src/chrome/test/base/test_launcher_utils.cc View 1 chunk +1 line, -3 lines 0 comments Download
M trunk/src/chrome/test/gpu/gpu_feature_browsertest.cc View 2 chunks +4 lines, -16 lines 0 comments Download
M trunk/src/content/browser/gpu/gpu_data_manager_impl_private.h View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/content/browser/gpu/gpu_data_manager_impl_private.cc View 6 chunks +5 lines, -36 lines 0 comments Download
M trunk/src/content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/content/public/common/content_switches.cc View 2 chunks +1 line, -5 lines 0 comments Download
M trunk/src/content/public/test/browser_test_base.cc View 1 chunk +1 line, -3 lines 0 comments Download
M trunk/src/gpu/config/gpu_control_list.h View 3 chunks +0 lines, -15 lines 0 comments Download
M trunk/src/gpu/config/gpu_control_list.cc View 4 chunks +1 line, -13 lines 0 comments Download
M trunk/src/gpu/config/software_rendering_list_json.cc View 8 chunks +4 lines, -38 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tapted
7 years, 2 months ago (2013-10-14 05:30:27 UTC) #1
tapted
Committed patchset #2 manually as r228431.
7 years, 2 months ago (2013-10-14 05:35:53 UTC) #2
gab
7 years, 2 months ago (2013-10-14 14:43:47 UTC) #3
Message was sent while issue was closed.
On 2013/10/14 05:35:53, tapted wrote:
> Committed patchset #2 manually as r228431.

That test indeed doesn't make sense in software compositing mode (which my CL
enables on XP/Vista bots).

Thanks Trent for taking care of this!
Gab

Powered by Google App Engine
This is Rietveld 408576698