Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2713773004: Extend the API exposed to JS to include a method that resolves urls against the summaryDataStore fi… (Closed)

Created:
3 years, 10 months ago by Jacob
Modified:
3 years, 10 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org, dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Extend the API exposed to JS to include a method that resolves urls against the summaryDataStore finding the closest match to a file with a summary or returning null if no urls match the path. Update dev_compiler web project to work with latest analyzer changes. Tweak API to work better with new summary paths and small polish items. BUG= R=jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/a1b8c1c6d5fa5c2790a3cd0b41201e6592f7ec69

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -35 lines) Patch
M pkg/dev_compiler/lib/src/compiler/compiler.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/dev_compiler/web/main.dart View 2 chunks +18 lines, -12 lines 0 comments Download
M pkg/dev_compiler/web/web_command.dart View 4 chunks +84 lines, -20 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jacob
Extend the API exposed to JS to include a method that resolves urls against the ...
3 years, 10 months ago (2017-02-23 18:27:18 UTC) #2
Jennifer Messerly
lgtm
3 years, 10 months ago (2017-02-23 18:31:46 UTC) #3
Jacob
3 years, 10 months ago (2017-02-23 19:29:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a1b8c1c6d5fa5c2790a3cd0b41201e6592f7ec69 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698