Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2713773003: Add test for paint underinvalidation fix with animated transform overflow. (Closed)
Patch Set: Set style attribute in test Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 817 matching lines...) Expand 10 before | Expand all | Expand 10 after
828 828
829 IntRect documentRect = layoutViewItem.documentRect(); 829 IntRect documentRect = layoutViewItem.documentRect();
830 if (scrollOrigin() == -documentRect.location() && 830 if (scrollOrigin() == -documentRect.location() &&
831 contentsSize() == documentRect.size()) 831 contentsSize() == documentRect.size())
832 return; 832 return;
833 833
834 if (needsLayout()) 834 if (needsLayout())
835 return; 835 return;
836 836
837 // If the visualViewport supplies scrollbars, we won't get a paint 837 // If the visualViewport supplies scrollbars, we won't get a paint
838 // invalidation from computeScrollbarExistence so we need to force one 838 // invalidation from computeScrollbarExistence so we need to force one.
839 // TODO(bokan): We should avoid computeScrollbarExistence otherwise.
840 if (visualViewportSuppliesScrollbars()) 839 if (visualViewportSuppliesScrollbars())
841 layoutViewItem.setMayNeedPaintInvalidation(); 840 layoutViewItem.setMayNeedPaintInvalidation();
842 841
843 // TODO(pdr): This should be refactored to just block scrollbar updates as 842 // TODO(pdr): This should be refactored to just block scrollbar updates as
844 // we are not in a scrollbar update here and m_inUpdateScrollbars has other 843 // we are not in a scrollbar update here and m_inUpdateScrollbars has other
845 // side effects. This scope is only for preventing a synchronous layout from 844 // side effects. This scope is only for preventing a synchronous layout from
846 // scroll origin changes which would not be allowed during style recalc. 845 // scroll origin changes which would not be allowed during style recalc.
847 InUpdateScrollbarsScope inUpdateScrollbarsScope(this); 846 InUpdateScrollbarsScope inUpdateScrollbarsScope(this);
848 847
849 bool shouldHaveHorizontalScrollbar = false; 848 bool shouldHaveHorizontalScrollbar = false;
(...skipping 4363 matching lines...) Expand 10 before | Expand all | Expand 10 after
5213 void FrameView::setAnimationHost( 5212 void FrameView::setAnimationHost(
5214 std::unique_ptr<CompositorAnimationHost> host) { 5213 std::unique_ptr<CompositorAnimationHost> host) {
5215 m_animationHost = std::move(host); 5214 m_animationHost = std::move(host);
5216 } 5215 }
5217 5216
5218 LayoutUnit FrameView::caretWidth() const { 5217 LayoutUnit FrameView::caretWidth() const {
5219 return LayoutUnit(getHostWindow()->windowToViewportScalar(1)); 5218 return LayoutUnit(getHostWindow()->windowToViewportScalar(1));
5220 } 5219 }
5221 5220
5222 } // namespace blink 5221 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/BUILD.gn ('k') | third_party/WebKit/Source/core/paint/PaintInvalidationTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698