Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2713773003: Add test for paint underinvalidation fix with animated transform overflow. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 815 matching lines...) Expand 10 before | Expand all | Expand 10 after
826 826
827 IntRect documentRect = layoutViewItem.documentRect(); 827 IntRect documentRect = layoutViewItem.documentRect();
828 if (scrollOrigin() == -documentRect.location() && 828 if (scrollOrigin() == -documentRect.location() &&
829 contentsSize() == documentRect.size()) 829 contentsSize() == documentRect.size())
830 return; 830 return;
831 831
832 if (needsLayout()) 832 if (needsLayout())
833 return; 833 return;
834 834
835 // If the visualViewport supplies scrollbars, we won't get a paint 835 // If the visualViewport supplies scrollbars, we won't get a paint
836 // invalidation from computeScrollbarExistence so we need to force one 836 // invalidation from computeScrollbarExistence so we need to force one.
837 // TODO(bokan): We should avoid computeScrollbarExistence otherwise.
838 if (visualViewportSuppliesScrollbars()) 837 if (visualViewportSuppliesScrollbars())
839 layoutViewItem.setMayNeedPaintInvalidation(); 838 layoutViewItem.setMayNeedPaintInvalidation();
840 839
841 // TODO(pdr): This should be refactored to just block scrollbar updates as 840 // TODO(pdr): This should be refactored to just block scrollbar updates as
842 // we are not in a scrollbar update here and m_inUpdateScrollbars has other 841 // we are not in a scrollbar update here and m_inUpdateScrollbars has other
843 // side effects. This scope is only for preventing a synchronous layout from 842 // side effects. This scope is only for preventing a synchronous layout from
844 // scroll origin changes which would not be allowed during style recalc. 843 // scroll origin changes which would not be allowed during style recalc.
845 InUpdateScrollbarsScope inUpdateScrollbarsScope(this); 844 InUpdateScrollbarsScope inUpdateScrollbarsScope(this);
846 845
847 bool shouldHaveHorizontalScrollbar = false; 846 bool shouldHaveHorizontalScrollbar = false;
(...skipping 4355 matching lines...) Expand 10 before | Expand all | Expand 10 after
5203 void FrameView::setAnimationHost( 5202 void FrameView::setAnimationHost(
5204 std::unique_ptr<CompositorAnimationHost> host) { 5203 std::unique_ptr<CompositorAnimationHost> host) {
5205 m_animationHost = std::move(host); 5204 m_animationHost = std::move(host);
5206 } 5205 }
5207 5206
5208 LayoutUnit FrameView::caretWidth() const { 5207 LayoutUnit FrameView::caretWidth() const {
5209 return LayoutUnit(getHostWindow()->windowToViewportScalar(1)); 5208 return LayoutUnit(getHostWindow()->windowToViewportScalar(1));
5210 } 5209 }
5211 5210
5212 } // namespace blink 5211 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/BUILD.gn » ('j') | third_party/WebKit/Source/web/tests/PaintInvalidationTest.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698