Add View::AddedToWidget and RemovedFromWidget.

ui/views/view_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/view.h"
 
 #include <stddef.h>
 
 #include <map>
 #include <memory>
@@ skipping 3317 matching lines @@
   EXPECT_TRUE(v4->has_remove_details());
   EXPECT_TRUE(v4->has_add_details());
   EXPECT_EQ(v2.get(), v4->remove_details().parent);
   EXPECT_EQ(&v1, v4->add_details().parent);
   EXPECT_EQ(v4, v4->add_details().child);
   EXPECT_EQ(v4, v4->remove_details().child);
   EXPECT_EQ(&v1, v4->remove_details().move_view);
   EXPECT_EQ(v2.get(), v4->add_details().move_view);
 }
 
+class WidgetObserverView : public View {
+ public:
+  WidgetObserverView();
+  ~WidgetObserverView() override;
+
+  void ResetTestState();
+
+  int added_to_widget_count() { return added_to_widget_count_; }
+  int removed_from_widget_count() { return removed_from_widget_count_; }
+
+ private:
+  void AddedToWidget() override;
+  void RemovedFromWidget() override;
+
+  int added_to_widget_count_;

[sky, 2017/03/01 20:26:51]

Either set in member initializer, or initialize to 0 here.

[msimonides, 2017/03/02 07:48:56]

Done.

+  int removed_from_widget_count_;
+
+  DISALLOW_COPY_AND_ASSIGN(WidgetObserverView);
+};
+
+WidgetObserverView::WidgetObserverView() {
+  ResetTestState();
+}
+
+WidgetObserverView::~WidgetObserverView() {}
+
+void WidgetObserverView::ResetTestState() {
+  added_to_widget_count_ = 0;
+  removed_from_widget_count_ = 0;
+}
+
+void WidgetObserverView::AddedToWidget() {
+  ++added_to_widget_count_;
+}
+
+void WidgetObserverView::RemovedFromWidget() {
+  ++removed_from_widget_count_;
+}
+
+// Verifies that AddedToWidget and RemovedFromWidget are called for a view when
+// it is added to hierarchy.
+// The tree looks like this:
+// widget
+// +-- root
+//
+// then v1 is added to root:
+//
+//     v1
+//     +-- v2
+//
+// finally v1 is removed from root.
+TEST_F(ViewTest, AddedToRemovedFromWidget) {
+  Widget widget;
+  Widget::InitParams params = CreateParams(Widget::InitParams::TYPE_POPUP);
+  params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
+  params.bounds = gfx::Rect(50, 50, 650, 650);
+  widget.Init(params);
+
+  View* root = widget.GetRootView();
+
+  WidgetObserverView v1;
+  WidgetObserverView v2;
+  WidgetObserverView v3;
+  v1.set_owned_by_client();
+  v2.set_owned_by_client();
+  v3.set_owned_by_client();
+
+  v1.AddChildView(&v2);
+  EXPECT_EQ(0, v2.added_to_widget_count());
+  EXPECT_EQ(0, v2.removed_from_widget_count());
+
+  root->AddChildView(&v1);
+  EXPECT_EQ(1, v1.added_to_widget_count());
+  EXPECT_EQ(0, v1.removed_from_widget_count());
+  EXPECT_EQ(1, v2.added_to_widget_count());
+  EXPECT_EQ(0, v2.removed_from_widget_count());
+
+  v2.AddChildView(&v3);
+  EXPECT_EQ(1, v2.added_to_widget_count());
+

[sky, 2017/03/01 20:26:51]

Add assertions that v1's counts haven't changed (maybe a reset on 3414 will make
it more readable).

[msimonides, 2017/03/02 07:48:56]

Done.

+  v1.ResetTestState();
+  v2.ResetTestState();
+
+  root->RemoveChildView(&v1);
+  EXPECT_EQ(0, v1.added_to_widget_count());
+  EXPECT_EQ(1, v1.removed_from_widget_count());
+  EXPECT_EQ(0, v2.added_to_widget_count());
+  EXPECT_EQ(1, v2.removed_from_widget_count());
+
+  v2.ResetTestState();
+  v1.RemoveChildView(&v2);
+  EXPECT_EQ(0, v2.removed_from_widget_count());
+
+  // Test move between parents in a single Widget.
+  v2.RemoveChildView(&v3);
+  v1.ResetTestState();
+  v2.ResetTestState();
+  v3.ResetTestState();
+
+  v1.AddChildView(&v2);
+  root->AddChildView(&v1);
+  root->AddChildView(&v3);
+  EXPECT_EQ(1, v1.added_to_widget_count());
+  EXPECT_EQ(1, v2.added_to_widget_count());
+  EXPECT_EQ(1, v3.added_to_widget_count());
+
+  v3.AddChildView(&v1);
+  EXPECT_EQ(1, v1.added_to_widget_count());
+  EXPECT_EQ(0, v1.removed_from_widget_count());
+  EXPECT_EQ(1, v2.added_to_widget_count());
+  EXPECT_EQ(0, v2.removed_from_widget_count());
+  EXPECT_EQ(1, v3.added_to_widget_count());
+  EXPECT_EQ(0, v3.removed_from_widget_count());
+
+  // Test move between widgets.
+  Widget second_widget;
+  params.bounds = gfx::Rect(150, 150, 650, 650);
+  second_widget.Init(params);
+
+  View* second_root = second_widget.GetRootView();
+
+  v1.ResetTestState();
+  v2.ResetTestState();
+  v3.ResetTestState();
+
+  second_root->AddChildView(&v1);
+  EXPECT_EQ(1, v1.removed_from_widget_count());
+  EXPECT_EQ(1, v1.added_to_widget_count());
+  EXPECT_EQ(1, v2.added_to_widget_count());
+  EXPECT_EQ(1, v2.removed_from_widget_count());
+  EXPECT_EQ(0, v3.added_to_widget_count());
+  EXPECT_EQ(0, v3.removed_from_widget_count());
+}
+
 // Verifies if the child views added under the root are all deleted when calling
 // RemoveAllChildViews.
 // The tree looks like this:
 // root
 // +-- child1
 //     +-- foo
 //         +-- bar0
 //         +-- bar1
 //         +-- bar2
 // +-- child2
@@ skipping 1514 matching lines @@
   std::unique_ptr<View> view = NewView();
   std::unique_ptr<View> child_view = NewView();
   std::unique_ptr<View> child_view2 = NewView();
   view->AddChildView(child_view.get());
   view->AddChildView(child_view2.get());
   view->ReorderChildView(child_view2.get(), 0);
   EXPECT_EQ(child_view2.get(), view_reordered());
 }
 
 }  // namespace views