Issue 271363002: Fix compile error on Win64 due to C++ warning 4275 occurring because an exported class ViewManagerC…

Issue 271363002: Fix compile error on Win64 due to C++ warning 4275 occurring because an exported class ViewManagerC… (Closed)

Created:
6 years, 7 months ago by ananta

Modified:
6 years, 7 months ago

Reviewers:
cpu_(ooo_6.6-7.5), darin (slow to review)

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix compile error on Win64 due to C++ warning 4275 occurring because an exported class ViewManagerConnection is deriving from a non exported interface IViewManager. Attempt 2 at fixing this. The previous approach of using NON_EXPORTED_BASE does not work in the template base derivation used in this class. Proposed fix is to explicitly disable this warning for Windows. BUG=none R=cpu@chromium.org, cpu TBR=darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269493

Patch Set 1 #

Patch Set 2 : Removed NON_EXPORTED_BASE #

Total comments: 2

Patch Set 3 : Removed spaces #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -2 lines)			Patch
	M	mojo/services/view_manager/view_manager_connection.h	View	1 2	2 chunks	+12 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

cpu_(ooo_6.6-7.5)

lgtm https://codereview.chromium.org/271363002/diff/20001/mojo/services/view_manager/view_manager_connection.h File mojo/services/view_manager/view_manager_connection.h (right): https://codereview.chromium.org/271363002/diff/20001/mojo/services/view_manager/view_manager_connection.h#newcode31 mojo/services/view_manager/view_manager_connection.h:31: #endif spaces in warnings should be consistent.

6 years, 7 months ago (2014-05-10 02:42:14 UTC) #2

ananta

https://codereview.chromium.org/271363002/diff/20001/mojo/services/view_manager/view_manager_connection.h File mojo/services/view_manager/view_manager_connection.h (right): https://codereview.chromium.org/271363002/diff/20001/mojo/services/view_manager/view_manager_connection.h#newcode31 mojo/services/view_manager/view_manager_connection.h:31: #endif On 2014/05/10 02:42:14, cpu wrote: > spaces in ...

6 years, 7 months ago (2014-05-10 02:44:25 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r269493.

Expand Messages | Collapse Messages