Don't inline functions that the parser decides shouldn't be inlined.

Don't inline functions that the parser decides shouldn't be inlined.

Fixes #28857
Fixes #28759

BUG=
R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/88b68b30b46e2f636e5e1ec8618d4bdb9b410244

[Cutch, 2017-02-23 20:10:42]

Description was changed from

==========
Don't inline functions that the parser decides shouldn't be inlined.

Fixes #28857

BUG=
==========

to

==========
Don't inline functions that the parser decides shouldn't be inlined.

Fixes #28857

BUG=
==========

[Cutch, 2017-02-23 20:10:42]

johnmccutchan@google.com changed reviewers:
+ rmacnak@google.com

[Cutch, 2017-02-23 20:13:26]

Description was changed from

==========
Don't inline functions that the parser decides shouldn't be inlined.

Fixes #28857

BUG=
==========

to

==========
Don't inline functions that the parser decides shouldn't be inlined.

Fixes #28857
Fixes #28759

BUG=
==========

[rmacnak, 2017-02-23 20:29:53]

lgtm

[Cutch, 2017-02-23 20:32:48]

Description was changed from

==========
Don't inline functions that the parser decides shouldn't be inlined.

Fixes #28857
Fixes #28759

BUG=
==========

to

==========
Don't inline functions that the parser decides shouldn't be inlined.

Fixes #28857
Fixes #28759

BUG=
R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/88b68b30b46e2f636e5e1ec8618d4bdb9b410244
==========

[Cutch, 2017-02-23 20:32:49]

Committed patchset #2 (id:20001) manually as
88b68b30b46e2f636e5e1ec8618d4bdb9b410244 (presubmit successful).

[Kevin Millikin (Google), 2017-02-24 14:32:28]

kmillikin@google.com changed reviewers:
+ kmillikin@google.com

[Kevin Millikin (Google), 2017-02-24 14:32:28]

I'm also bit nervous about this code in the parser:

  func.set_is_inlinable(!FLAG_causal_async_stacks);

It means that we could potentially get into a case where a function we determine
is not inlinable for some good reason, is actually inlinable after all because
FLAG_causal_async_stacks is false.  I'd rather have:

  if (FLAG_causal_async_stacks) func.set_is_inlinable(false);

https://codereview.chromium.org/2713593004/diff/20001/runtime/vm/flow_graph_i...
File runtime/vm/flow_graph_inliner.cc (right):

https://codereview.chromium.org/2713593004/diff/20001/runtime/vm/flow_graph_i...
runtime/vm/flow_graph_inliner.cc:784: // As a side effect of parsing the
function, it may be marked
We already know whether the function is async or async* (when we created it), so
we shouldn't need to parse it.  I suggest marking async and async* functions not
inlinable at the same time that their modifier is set and letting the earlier
CanBeInlined() test in this method catch them without going through all the
other work.