Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2713553011: Split parser tests that exercise class members to their own class. (Closed)

Created:
3 years, 10 months ago by Paul Berry
Modified:
3 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Split parser tests that exercise class members to their own class. In future CLs I will get these tests to pass. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/0c1facfd9b7bb84f8c8db1a718d77c41f6125f86

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2240 lines, -1837 lines) Patch
M pkg/analyzer/test/generated/parser_fasta_test.dart View 5 chunks +383 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 10 chunks +1848 lines, -1836 lines 0 comments Download
M pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart View 4 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 10 months ago (2017-02-23 22:10:15 UTC) #2
scheglov
LGTM
3 years, 10 months ago (2017-02-23 22:13:21 UTC) #3
Paul Berry
3 years, 10 months ago (2017-02-23 22:22:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0c1facfd9b7bb84f8c8db1a718d77c41f6125f86 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698