mac: Periodically shim new malloc zones immediately after startup.

base/allocator/allocator_interception_mac.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_ALLOCATOR_ALLOCATOR_INTERCEPTION_MAC_H_
 #define BASE_ALLOCATOR_ALLOCATOR_INTERCEPTION_MAC_H_
 
 #include <stddef.h>
 
 #include "base/base_export.h"
@@ skipping 17 matching lines @@
 
 // Calls the original implementation of malloc/calloc prior to interception.
 bool UncheckedMallocMac(size_t size, void** result);
 bool UncheckedCallocMac(size_t num_items, size_t size, void** result);
 
 // Intercepts calls to default and purgeable malloc zones. Intercepts Core
 // Foundation and Objective-C allocations.
 // Has no effect on the default malloc zone if the allocator shim already
 // performs that interception.
 BASE_EXPORT void InterceptAllocationsMac();
+
+// Periodically checks for, and shims new malloc zones.

[Mark Mentovai, 2017/02/23 02:26:17]

This has an expiration date on it, which is kind of important. Mention that
here.

[erikchen, 2017/04/03 06:44:41]

Done.

+BASE_EXPORT void PeriodicallyShimNewMallocZones();

[Mark Mentovai, 2017/02/23 02:26:17]

And this one only does what it says if a certain command-line argument is
present. Its name doesn’t give that away at all, and there’s no comment saying
so either.

Both of these are kind of important for callers to know without having to read
the implementation.

[Primiano Tucci (use gerrit), 2017/02/23 14:41:57]

+1, or alternatively you can move the cmdline check in the caller, which would
make the code in browser_main_loop more reassuring.

[erikchen, 2017/04/03 06:44:41]

I did what primiano suggested.

+
 }  // namespace allocator
 }  // namespace base
 
 #endif  // BASE_ALLOCATOR_ALLOCATOR_INTERCEPTION_MAC_H_