Issue 271353002: Fix compile error on Win64 due to C++ warning 4275 occurring because an exported class ViewManagerC…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 271353002: Fix compile error on Win64 due to C++ warning 4275 occurring because an exported class ViewManagerC… (Closed)

Created:
6 years, 7 months ago by ananta

Modified:
6 years, 7 months ago

Reviewers:
darin (slow to review), cpu_(ooo_6.6-7.5)

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix compile error on Win64 due to C++ warning 4275 occurring because an exported class ViewManagerConnection is deriving from a non exported interface IViewManager BUG=none R=cpu@chromium.org TBR=darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269471

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	mojo/services/view_manager/view_manager_connection.h	View		2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

cpu_(ooo_6.6-7.5)

this is also broken in 32 bits, I don't understand how this could have gone ...

6 years, 7 months ago (2014-05-10 01:31:04 UTC) #3

ananta

Committed patchset #1 manually as r269471 (tree was closed).

6 years, 7 months ago (2014-05-10 01:32:24 UTC) #4

darin (slow to review)

6 years, 7 months ago (2014-05-10 01:42:32 UTC) #5

Try bots never complained :-(

Thanks Ananta!

On Fri, May 9, 2014 at 6:31 PM, <cpu@chromium.org> wrote:

> this is also broken in 32 bits, I don't understand how this could have
> gone via
> the CQ... hmmm
>
>
> https://codereview.chromium.org/271353002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Expand Messages | Collapse Messages