Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7771)

Unified Diff: chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc

Issue 2713513009: cros: Break BaseScreenHandler into two classes. (Closed)
Patch Set: Add comments, fix compile Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
index 1c5bf8e81b15d26bb2069c49eb8d7c2595e19514..7a713675cced3710e7e7c7aeef3641f5711748b3 100644
--- a/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
+++ b/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
@@ -228,7 +228,8 @@ GaiaScreenHandler::GaiaContext::GaiaContext() {}
GaiaScreenHandler::GaiaScreenHandler(
CoreOobeView* core_oobe_view,
const scoped_refptr<NetworkStateInformer>& network_state_informer)
- : network_state_informer_(network_state_informer),
+ : BaseScreenHandler(kScreenId),
+ network_state_informer_(network_state_informer),
core_oobe_view_(core_oobe_view),
weak_factory_(this) {
DCHECK(network_state_informer_.get());
@@ -461,7 +462,7 @@ void GaiaScreenHandler::OnPortalDetectionCompleted(
if (offline_login_is_active() ||
IsOnline(captive_portal_status_) == IsOnline(previous_status) ||
disable_restrictive_proxy_check_for_test_ ||
- GetCurrentScreen() != OobeScreen::SCREEN_GAIA_SIGNIN)
+ GetCurrentScreen() != kScreenId)
return;
LoadAuthExtension(true /* force */, false /* offline */);

Powered by Google App Engine
This is Rietveld 408576698