Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: chrome/browser/ui/webui/chromeos/login/update_screen_handler.cc

Issue 2713513009: cros: Break BaseScreenHandler into two classes. (Closed)
Patch Set: Add comments, fix compile Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/chromeos/login/update_screen_handler.h" 5 #include "chrome/browser/ui/webui/chromeos/login/update_screen_handler.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/values.h" 9 #include "base/values.h"
10 #include "chrome/browser/chromeos/login/oobe_screen.h" 10 #include "chrome/browser/chromeos/login/oobe_screen.h"
11 #include "chrome/browser/chromeos/login/screens/update_screen.h" 11 #include "chrome/browser/chromeos/login/screens/update_screen.h"
12 #include "chrome/grit/chromium_strings.h" 12 #include "chrome/grit/chromium_strings.h"
13 #include "chrome/grit/generated_resources.h" 13 #include "chrome/grit/generated_resources.h"
14 #include "components/login/localized_values_builder.h" 14 #include "components/login/localized_values_builder.h"
15 15
16 namespace { 16 namespace {
17 17
18 const char kJsScreenPath[] = "login.UpdateScreen"; 18 const char kJsScreenPath[] = "login.UpdateScreen";
19 19
20 } // namespace 20 } // namespace
21 21
22 namespace chromeos { 22 namespace chromeos {
23 23
24 UpdateScreenHandler::UpdateScreenHandler() { 24 UpdateScreenHandler::UpdateScreenHandler() : BaseScreenHandler(kScreenId) {
25 set_call_js_prefix(kJsScreenPath); 25 set_call_js_prefix(kJsScreenPath);
26 } 26 }
27 27
28 UpdateScreenHandler::~UpdateScreenHandler() { 28 UpdateScreenHandler::~UpdateScreenHandler() {
29 if (screen_) 29 if (screen_)
30 screen_->OnViewDestroyed(this); 30 screen_->OnViewDestroyed(this);
31 } 31 }
32 32
33 void UpdateScreenHandler::DeclareLocalizedValues( 33 void UpdateScreenHandler::DeclareLocalizedValues(
34 ::login::LocalizedValuesBuilder* builder) { 34 ::login::LocalizedValuesBuilder* builder) {
(...skipping 28 matching lines...) Expand all
63 Show(); 63 Show();
64 show_on_init_ = false; 64 show_on_init_ = false;
65 } 65 }
66 } 66 }
67 67
68 void UpdateScreenHandler::Show() { 68 void UpdateScreenHandler::Show() {
69 if (!page_is_ready()) { 69 if (!page_is_ready()) {
70 show_on_init_ = true; 70 show_on_init_ = true;
71 return; 71 return;
72 } 72 }
73 ShowScreen(OobeScreen::SCREEN_OOBE_UPDATE); 73 ShowScreen(kScreenId);
74 } 74 }
75 75
76 void UpdateScreenHandler::Hide() { 76 void UpdateScreenHandler::Hide() {
77 } 77 }
78 78
79 void UpdateScreenHandler::Bind(UpdateScreen* screen) { 79 void UpdateScreenHandler::Bind(UpdateScreen* screen) {
80 screen_ = screen; 80 screen_ = screen;
81 BaseScreenHandler::SetBaseScreen(screen_); 81 BaseScreenHandler::SetBaseScreen(screen_);
82 } 82 }
83 83
84 void UpdateScreenHandler::Unbind() { 84 void UpdateScreenHandler::Unbind() {
85 screen_ = nullptr; 85 screen_ = nullptr;
86 BaseScreenHandler::SetBaseScreen(nullptr); 86 BaseScreenHandler::SetBaseScreen(nullptr);
87 } 87 }
88 88
89 } // namespace chromeos 89 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698