third_party/WebKit/Source/core/frame/DOMWindowTimers.cpp - Issue 2713413002: Blink bindings: use v8 to enforce method call access checks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/DOMWindowTimers.cpp

Issue 2713413002: Blink bindings: use v8 to enforce method call access checks (Closed)

Patch Set: Restore comment Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/DOMWindowTimers.cpp

diff --git a/third_party/WebKit/Source/core/frame/DOMWindowTimers.cpp b/third_party/WebKit/Source/core/frame/DOMWindowTimers.cpp

index ba4232ef62ab4ba376ffb57b022cecbe8d6932a5..aeef8217f0134e24772c6491660eb6f7c1c6158c 100644

--- a/third_party/WebKit/Source/core/frame/DOMWindowTimers.cpp

+++ b/third_party/WebKit/Source/core/frame/DOMWindowTimers.cpp

@@ -49,6 +49,8 @@ static bool isAllowed(ScriptState* scriptState,

bool isEval) {

if (executionContext->isDocument()) {

Document* document = static_cast<Document*>(executionContext);

+ if (!document->frame())

+ return false;

if (isEval &&

!document->contentSecurityPolicy()->allowEval(

scriptState, ContentSecurityPolicy::SendReport,