third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp - Issue 2713413002: Blink bindings: use v8 to enforce method call access checks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp

Issue 2713413002: Blink bindings: use v8 to enforce method call access checks (Closed)

Patch Set: Restore comment Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/fetch/chromium/discarded-window.html ('K') | « third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackFunctions.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexed.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp

index 0f952792e96fdd93fede4b255a8020f040385c6c..e2090788d122ae67f1f67af37bdc304f0baea3d5 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp

@@ -113,7 +113,7 @@ const V8DOMConfiguration::AccessorConfiguration V8TestExceptionAccessors[] = {

};

const V8DOMConfiguration::MethodConfiguration V8TestExceptionMethods[] = {

- {"toString", V8TestException::toStringMethodCallback, nullptr, 0, static_cast<v8::PropertyAttribute>(v8::DontEnum), V8DOMConfiguration::OnPrototype, V8DOMConfiguration::CheckHolder},

+ {"toString", V8TestException::toStringMethodCallback, nullptr, 0, static_cast<v8::PropertyAttribute>(v8::DontEnum), V8DOMConfiguration::OnPrototype, V8DOMConfiguration::CheckHolder, V8DOMConfiguration::DoNotCheckAccess},

};

void V8TestException::constructorCallback(const v8::FunctionCallbackInfo<v8::Value>& info) {