Blink bindings: use v8 to enforce method call access checks

third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 31 matching lines @@
   STATIC_ONLY(V8DOMConfiguration);
 
  public:
   // The following Configuration structs and install methods are used for
   // setting multiple properties on ObjectTemplate / FunctionTemplate, used
   // from the generated bindings initialization (ConfigureXXXTemplate).
   // This greatly reduces the binary size by moving from code driven setup to
   // data table driven setup.
 
   // Bitflags to show where the member will be defined.
-  enum PropertyLocationConfiguration {
+  enum PropertyLocationConfiguration : unsigned {
     OnInstance = 1 << 0,
     OnPrototype = 1 << 1,
     OnInterface = 1 << 2,
   };
 
-  enum HolderCheckConfiguration {
+  // TODO(dcheng): Make these enum classes.
+  enum HolderCheckConfiguration : unsigned {
     CheckHolder,
     DoNotCheckHolder,
   };
 
+  enum AccessCheckConfiguration : unsigned {
+    CheckAccess,
+    DoNotCheckAccess,
+  };
+
   typedef v8::Local<v8::Private> (*CachedAccessorCallback)(v8::Isolate*);
 
   // AttributeConfiguration translates into calls to SetNativeDataProperty() on
   // either the instance or the prototype ObjectTemplate, based on
   // |propertyLocationConfiguration|.
   struct AttributeConfiguration {
     AttributeConfiguration& operator=(const AttributeConfiguration&) = delete;
     DISALLOW_NEW();
     const char* const name;
     v8::AccessorNameGetterCallback getter;
     v8::AccessorNameSetterCallback setter;
     v8::AccessorNameGetterCallback getterForMainWorld;
     v8::AccessorNameSetterCallback setterForMainWorld;
     // TODO(vogelheim): This has to be removed too since it's only used in
     //                  accessors.
     // The accessor's 'result' is stored in a private property.
     CachedAccessorCallback cachedAccessorCallback;
     const WrapperTypeInfo* data;
-    unsigned attribute : 8;  // v8::PropertyAttribute
-    unsigned
-        propertyLocationConfiguration : 3;  // PropertyLocationConfiguration
-    unsigned holderCheckConfiguration : 1;  // HolderCheckConfiguration
+    // v8::PropertyAttribute
+    unsigned attribute : 8;
+    // PropertyLocationConfiguration
+    unsigned propertyLocationConfiguration : 3;
+    // HolderCheckConfiguration
+    unsigned holderCheckConfiguration : 1;
   };
 
   static void installAttributes(v8::Isolate*,
                                 const DOMWrapperWorld&,
                                 v8::Local<v8::ObjectTemplate> instanceTemplate,
                                 v8::Local<v8::ObjectTemplate> prototypeTemplate,
                                 const AttributeConfiguration*,
                                 size_t attributeCount);
 
   static void installAttribute(v8::Isolate*,
@@ skipping 28 matching lines @@
     AccessorConfiguration& operator=(const AccessorConfiguration&) = delete;
     DISALLOW_NEW();
     const char* const name;
     v8::FunctionCallback getter;
     v8::FunctionCallback setter;
     v8::FunctionCallback getterForMainWorld;
     v8::FunctionCallback setterForMainWorld;
     // The accessor's 'result' is stored in a private property.
     CachedAccessorCallback cachedAccessorCallback;
     const WrapperTypeInfo* data;
-    unsigned attribute : 8;  // v8::PropertyAttribute
-    unsigned
-        propertyLocationConfiguration : 3;  // PropertyLocationConfiguration
-    unsigned holderCheckConfiguration : 1;  // HolderCheckConfiguration
+    // v8::PropertyAttribute
+    unsigned attribute : 8;
+    // PropertyLocationConfiguration
+    unsigned propertyLocationConfiguration : 3;
+    // HolderCheckConfiguration
+    unsigned holderCheckConfiguration : 1;
   };
 
   static void installAccessors(
       v8::Isolate*,
       const DOMWrapperWorld&,
       v8::Local<v8::ObjectTemplate> instanceTemplate,
       v8::Local<v8::ObjectTemplate> prototypeTemplate,
       v8::Local<v8::FunctionTemplate> interfaceTemplate,
       v8::Local<v8::Signature>,
       const AccessorConfiguration*,
@@ skipping 79 matching lines @@
     }
     v8::FunctionCallback callbackForWorld(const DOMWrapperWorld& world) const {
       return world.isMainWorld() && callbackForMainWorld ? callbackForMainWorld
                                                          : callback;
     }
 
     const char* const name;
     v8::FunctionCallback callback;
     v8::FunctionCallback callbackForMainWorld;
     int length;
-    unsigned attribute : 8;  // v8::PropertyAttribute
-    unsigned
-        propertyLocationConfiguration : 3;  // PropertyLocationConfiguration
-    unsigned holderCheckConfiguration : 1;  // HolderCheckConfiguration
+    // v8::PropertyAttribute
+    unsigned attribute : 8;
+    // PropertyLocationConfiguration
+    unsigned propertyLocationConfiguration : 3;
+    // HolderCheckConfiguration
+    unsigned holderCheckConfiguration : 1;
+    // AccessCheckConfiguration
+    unsigned accessCheckConfiguration : 1;
   };
 
   struct SymbolKeyedMethodConfiguration {
     SymbolKeyedMethodConfiguration& operator=(
         const SymbolKeyedMethodConfiguration&) = delete;
     DISALLOW_NEW();
     v8::Local<v8::Name> methodName(v8::Isolate* isolate) const {
       return getSymbol(isolate);
     }
     v8::FunctionCallback callbackForWorld(const DOMWrapperWorld&) const {
       return callback;
     }
 
     v8::Local<v8::Symbol> (*getSymbol)(v8::Isolate*);
     v8::FunctionCallback callback;
     // SymbolKeyedMethodConfiguration doesn't support per-world bindings.
     int length;
-    unsigned attribute : 8;  // v8::PropertyAttribute
-    unsigned
-        propertyLocationConfiguration : 3;  // PropertyLocationConfiguration
-    unsigned holderCheckConfiguration : 1;  // HolderCheckConfiguration
+    // v8::PropertyAttribute
+    unsigned attribute : 8;
+    // PropertyLocationConfiguration
+    unsigned propertyLocationConfiguration : 3;
+    // HolderCheckConfiguration
+    unsigned holderCheckConfiguration : 1;
+    // AccessCheckConfiguration
+    unsigned accessCheckConfiguration : 1;
   };
 
   static void installMethods(v8::Isolate*,
                              const DOMWrapperWorld&,
                              v8::Local<v8::ObjectTemplate> instanceTemplate,
                              v8::Local<v8::ObjectTemplate> prototypeTemplate,
                              v8::Local<v8::FunctionTemplate> interfaceTemplate,
                              v8::Local<v8::Signature>,
                              const MethodConfiguration*,
                              size_t methodCount);
@@ skipping 36 matching lines @@
   // Sets the class string of platform objects, interface prototype objects,
   // etc.  See also http://heycam.github.io/webidl/#dfn-class-string
   static void setClassString(v8::Isolate*,
                              v8::Local<v8::ObjectTemplate>,
                              const char* classString);
 };
 
 }  // namespace blink
 
 #endif  // V8DOMConfiguration_h