Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2713393002: dart2js: HGetLength may become fixed (Closed)

Created:
3 years, 10 months ago by sra1
Modified:
3 years, 9 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: HGetLength may become fixed We may not know initially that the input to HGetLength is fixed-length, but discover so later. Most notably this happens with --trust-type-annotations, since the HTypeKnown for 'trusting' the type hides the underlying type, but it also happens as a consequence of local dataflow and other optimizations. BUG= R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/50b6107eecc808f3227aee938c01f7ebd21a2d4b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M pkg/compiler/lib/src/ssa/optimize.dart View 2 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
sra1
3 years, 10 months ago (2017-02-26 07:46:13 UTC) #2
sra1
3 years, 9 months ago (2017-02-27 18:43:25 UTC) #4
Emily Fortuna
lgtm
3 years, 9 months ago (2017-02-27 18:45:37 UTC) #5
sra1
3 years, 9 months ago (2017-02-27 20:33:34 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
50b6107eecc808f3227aee938c01f7ebd21a2d4b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698