chrome/browser/resources/settings/downloads_page/downloads_page.html - Issue 2713343003: MD Settings: Add "Auto Open" setting to Downloads page UI.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/downloads_page/downloads_page.html

Issue 2713343003: MD Settings: Add "Auto Open" setting to Downloads page UI. (Closed)

Patch Set: fix merge? Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/settings/downloads_page/compiled_resources2.gyp ('k') | chrome/browser/resources/settings/downloads_page/downloads_page.js » ('j') | chrome/browser/resources/settings/downloads_page/downloads_page.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <link rel="import" href="chrome://resources/html/polymer.html">	1 <link rel="import" href="chrome://resources/html/polymer.html">

	2 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html">

2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classe s/iron-flex-layout.html">	3 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classe s/iron-flex-layout.html">

3 <link rel="import" href="../controls/controlled_button.html">	4 <link rel="import" href="../controls/controlled_button.html">

4 <link rel="import" href="../controls/settings_toggle_button.html">	5 <link rel="import" href="../controls/settings_toggle_button.html">

5 <link rel="import" href="../settings_shared_css.html">	6 <link rel="import" href="../settings_shared_css.html">

6	7

7 <dom-module id="settings-downloads-page">	8 <dom-module id="settings-downloads-page">

8 <template>	9 <template>

9 <style include="settings-shared"></style>	10 <style include="settings-shared"></style>

10 <div class="settings-box first two-line">	11 <div class="settings-box first two-line">

11 <div class="start">	12 <div class="start">

(...skipping 22 matching lines...) Expand all Loading...
34 label="$i18n{promptForDownload}">	35 label="$i18n{promptForDownload}">

35 </settings-toggle-button>	36 </settings-toggle-button>

36 <if expr="chromeos">	37 <if expr="chromeos">

37 <settings-toggle-button	38 <settings-toggle-button

38 pref="{{prefs.gdata.disabled}}"	39 pref="{{prefs.gdata.disabled}}"

39 label="$i18n{disconnectGoogleDriveAccount}"	40 label="$i18n{disconnectGoogleDriveAccount}"

40 hidden="[[!pageVisibility.googleDrive]]">	41 hidden="[[!pageVisibility.googleDrive]]">

41 </settings-toggle-button>	42 </settings-toggle-button>

42 </if>	43 </if>

43 </div>	44 </div>

	45 <div class="settings-box" hidden="[[!autoOpenDownloads_]]">
	Dan Beam 2017/02/27 05:50:36 can you make this a dom-if instead of binding to h can you make this a dom-if instead of binding to hidden? tommycli 2017/02/28 00:47:26 Done. Show quoted text On 2017/02/27 05:50:36, Dan Beam wrote: > can you make this a dom-if instead of binding to hidden? Done.
	46 <div class="start">

	47 $i18n{openFileTypesAutomatically}

	48 </div>

	49 <div class="secondary-action">

	50 <paper-button on-tap="onClearAutoOpenFileTypesTap_"

	51 class="secondary-button">

	52 $i18n{clear}

	53 </paper-button>

	54 </div>

	55 </div>

44 </template>	56 </template>

45 <script src="downloads_page.js"></script>	57 <script src="downloads_page.js"></script>

46 </dom-module>	58 </dom-module>

OLD	NEW