Remove redundant separator at end of the spelling correction context menu

chrome/browser/renderer_context_menu/render_view_context_menu.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_context_menu/render_view_context_menu.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <set>
@@ skipping 1392 matching lines @@
   menu_model_.AddItemWithStringId(IDC_CONTENT_CONTEXT_COPY,
                                   IDS_CONTENT_CONTEXT_COPY);
   menu_model_.AddItemWithStringId(IDC_CONTENT_CONTEXT_PASTE,
                                   IDS_CONTENT_CONTEXT_PASTE);
   if (params_.misspelled_word.empty()) {
     menu_model_.AddItemWithStringId(IDC_CONTENT_CONTEXT_PASTE_AND_MATCH_STYLE,
                                     IDS_CONTENT_CONTEXT_PASTE_AND_MATCH_STYLE);
     menu_model_.AddItemWithStringId(IDC_CONTENT_CONTEXT_SELECTALL,
                                     IDS_CONTENT_CONTEXT_SELECTALL);
   }
-
-  menu_model_.AddSeparator(ui::NORMAL_SEPARATOR);

[lazyboy, 2017/02/28 00:29:02]

This is prone to further bugs I think:
If group items that come after AppendEditableItems() do not prepend a separator
then we will have two groups unintentionally merged?

Instead we can remove a separator at the end of ::InitMenu(), sth like:
if (menu_model_.GetItemCount() > 0 &&
menu_model_.GetTypeAt(menu_model_.GetItemCount()-1) == TYPE_SEPARATOR)
  menu_model_.RemoveItemAt(...)

WDYT?

[edwardjung, 2017/02/28 01:01:06]

Done.

 }
 
 void RenderViewContextMenu::AppendLanguageSettings() {
   const bool use_spelling = !chrome::IsRunningInForcedAppMode();
   if (!use_spelling)
     return;
 
 #if defined(OS_MACOSX)
   menu_model_.AddItemWithStringId(IDC_CONTENT_CONTEXT_LANGUAGE_SETTINGS,
                                   IDS_CONTENT_CONTEXT_LANGUAGE_SETTINGS);
@@ skipping 1080 matching lines @@
 void RenderViewContextMenu::PluginActionAt(
     const gfx::Point& location,
     const WebPluginAction& action) {
   source_web_contents_->GetRenderViewHost()->
       ExecutePluginActionAtLocation(location, action);
 }
 
 Browser* RenderViewContextMenu::GetBrowser() const {
   return chrome::FindBrowserWithWebContents(embedder_web_contents_);
 }