Adjust ellision strategy for omnibox search chip.

Adjust ellision strategy for omnibox search chip.

- Collapse from full width to an elided version of the text (which
  leaves off "Search" and truncates the engine name), but don't allow
  the chip to shrink any further or disappear completely.

- Forward unhandled clicks in the location bar (including those on the
  search chip) to the omnibox textfield. Forwarding all events felt
  wrong because it changed the mouse cursor to an I-bar when hovering
  the search chip.

BUG=694152

[Evan Stade, 2017-02-24 18:40:12]

estade@chromium.org changed reviewers:
+ pkasting@chromium.org

[Evan Stade, 2017-02-24 18:44:33]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 18:45:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 19:08:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 19:08:53]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Peter Kasting, 2017-02-25 06:17:11]

I'd still like to see what Max thinks of the idea of just collapsing to the blue
magnifying glass.

https://codereview.chromium.org/2713253002/diff/1/chrome/browser/ui/location_...
File chrome/browser/ui/location_bar/location_bar_util.cc (right):

https://codereview.chromium.org/2713253002/diff/1/chrome/browser/ui/location_...
chrome/browser/ui/location_bar/location_bar_util.cc:23: // Show at least 4
characters plus an ellipsis.
Nit: This formatting is wacky.  How about:

  base::string16 min_string(description, 0, chop_index);
  if (chop_index == base::string16::npos) {
    // Show at least 4 characters plus an ellipsis.
    min_string = gfx::TruncateString(description, 5, gfx::WORD_BREAK);
  }

https://codereview.chromium.org/2713253002/diff/1/chrome/browser/ui/views/loc...
File chrome/browser/ui/views/location_bar/location_bar_view.cc (right):

https://codereview.chromium.org/2713253002/diff/1/chrome/browser/ui/views/loc...
chrome/browser/ui/views/location_bar/location_bar_view.cc:609: return
static_cast<views::View*>(omnibox_view_)->OnMousePressed(event);
I don't like forwarding these.  It seems strange given that clicks on the
location icon text don't result in selecting the omnibox text.

[Evan Stade, 2017-03-07 18:10:22]

https://codereview.chromium.org/2713253002/diff/1/chrome/browser/ui/views/loc...
File chrome/browser/ui/views/location_bar/location_bar_view.cc (right):

https://codereview.chromium.org/2713253002/diff/1/chrome/browser/ui/views/loc...
chrome/browser/ui/views/location_bar/location_bar_view.cc:609: return
static_cast<views::View*>(omnibox_view_)->OnMousePressed(event);
On 2017/02/25 06:17:11, Peter Kasting wrote:
> I don't like forwarding these.  It seems strange given that clicks on the
> location icon text don't result in selecting the omnibox text.

well the location icon is usually a security indicator, and clicking it does do
something rather than nothing (as clicking on search currently does nothing). I
think this feels nice but I'll split it off into a separate cl and discussion.

[Peter Kasting, 2017-03-07 21:03:29]

Is there something I should do with this CL at this point, or has it been
superseded?

[Evan Stade, 2017-03-07 22:39:15]

On 2017/03/07 21:03:29, Peter Kasting wrote:
> Is there something I should do with this CL at this point, or has it been
> superseded?

the latter --- it can be ignored.