Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5092)

Unified Diff: chrome/renderer/safe_browsing/threat_dom_details.h

Issue 2713233002: Update ThreatDOMDetails to be able to collect non-resource HTML Elements based on their attributes. (Closed)
Patch Set: Sync Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/safe_browsing/threat_dom_details.h
diff --git a/chrome/renderer/safe_browsing/threat_dom_details.h b/chrome/renderer/safe_browsing/threat_dom_details.h
index 2cab3d2814d21acaeea7592b57242b2fb2c562da..41230194bfc3ffc1f3b3e90a25d38f3eb41eef50 100644
--- a/chrome/renderer/safe_browsing/threat_dom_details.h
+++ b/chrome/renderer/safe_browsing/threat_dom_details.h
@@ -12,12 +12,29 @@
#include <vector>
#include "base/compiler_specific.h"
+#include "base/feature_list.h"
#include "content/public/renderer/render_frame_observer.h"
struct SafeBrowsingHostMsg_ThreatDOMDetails_Node;
namespace safe_browsing {
+extern const base::Feature kThreatDomDetailsTagAndAttributeFeature;
+extern const char kTagAndAttributeParamName[];
+
+// Represents the tag name of an HTML Element and its associated attributes.
+// Used to determine which elements to collect. Populated from the param value
+// of |kThreatDomDetailsTagAndAttributeFeature|.
+class TagAndAttributesItem {
+ public:
+ TagAndAttributesItem();
+ TagAndAttributesItem(const TagAndAttributesItem& item);
+ ~TagAndAttributesItem();
+
+ std::string tag_name;
+ std::vector<std::string> attributes;
+};
+
// There is one ThreatDOMDetails per RenderFrame.
class ThreatDOMDetails : public content::RenderFrameObserver {
public:
@@ -45,6 +62,10 @@ class ThreatDOMDetails : public content::RenderFrameObserver {
void OnGetThreatDOMDetails();
+ // A list of tag names and associates attributes, used to determine which
+ // elements need to be collected.
+ std::vector<TagAndAttributesItem> tag_and_attributes_list_;
+
DISALLOW_COPY_AND_ASSIGN(ThreatDOMDetails);
};
« no previous file with comments | « chrome/browser/safe_browsing/threat_details_unittest.cc ('k') | chrome/renderer/safe_browsing/threat_dom_details.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698