Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 2713203002: Fix typing for lookup-map test. (Closed)

Created:
3 years, 10 months ago by floitsch
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M pkg/lookup_map/test/lookup_map_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
floitsch
TBR since it's making the bot red.
3 years, 10 months ago (2017-02-24 14:57:53 UTC) #2
floitsch
Committed patchset #1 (id:1) manually as 37b7a1ac9cebb9b073b7616377f1e92631c23e67 (presubmit successful).
3 years, 10 months ago (2017-02-24 14:58:16 UTC) #4
Siggi Cherem (dart-lang)
lgtm Just curious how did this start failing all the sudden? Was it failing on ...
3 years, 9 months ago (2017-03-09 05:20:25 UTC) #5
floitsch
3 years, 9 months ago (2017-03-09 15:19:59 UTC) #6
Message was sent while issue was closed.
Sorry. I don't remember why this was red.

I think it was another test that failed.

Powered by Google App Engine
This is Rietveld 408576698